You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/16 06:10:56 UTC

[GitHub] [incubator-shardingsphere] kimmking opened a new pull request #4774: fix curator watch timeout unit test

kimmking opened a new pull request #4774: fix curator watch timeout unit test
URL: https://github.com/apache/incubator-shardingsphere/pull/4774
 
 
   Fixes #4773 .
   
   Changes proposed in this pull request:
   - set an independent key for each watched test case to avoid only publishing parent event
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4774: fix curator watch timeout unit test

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4774: fix curator watch timeout unit test
URL: https://github.com/apache/incubator-shardingsphere/pull/4774#issuecomment-599369493
 
 
   ## Pull Request Test Coverage Report for [Build 10271](https://coveralls.io/builds/29376001)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.005%**) to **59.64%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29376001/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29376001/badge)](https://coveralls.io/builds/29376001) |
   | :-- | --: |
   | Change from base [Build 1082](https://coveralls.io/builds/29375594): |  -0.005% |
   | Covered Lines: | 12451 |
   | Relevant Lines: | 20877 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4774: fix curator watch timeout unit test

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4774: fix curator watch timeout unit test
URL: https://github.com/apache/incubator-shardingsphere/pull/4774#issuecomment-599369493
 
 
   ## Pull Request Test Coverage Report for [Build 2112](https://coveralls.io/builds/29375624)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.07%**) to **59.716%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29375624/badge)](https://coveralls.io/builds/29375624) |
   | :-- | --: |
   | Change from base [Build 1082](https://coveralls.io/builds/29375594): |  0.07% |
   | Covered Lines: | 12467 |
   | Relevant Lines: | 20877 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4774: fix curator watch timeout unit test

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4774: fix curator watch timeout unit test
URL: https://github.com/apache/incubator-shardingsphere/pull/4774#issuecomment-599369493
 
 
   ## Pull Request Test Coverage Report for [Build 2114](https://coveralls.io/builds/29376186)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **59.645%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29376186/badge)](https://coveralls.io/builds/29376186) |
   | :-- | --: |
   | Change from base [Build 1082](https://coveralls.io/builds/29375594): |  0.0% |
   | Covered Lines: | 12452 |
   | Relevant Lines: | 20877 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4774: fix curator watch timeout unit test

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4774: fix curator watch timeout unit test
URL: https://github.com/apache/incubator-shardingsphere/pull/4774
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services