[GitHub] [hive] nrg4878 commented on a diff in pull request #4537: HIVE-27554: added control to JDBCBrowser client URL

["nrg4878 (via GitHub)" <gi...@apache.org>]

nrg4878 commented on code in PR #4537:
URL: https://github.com/apache/hive/pull/4537#discussion_r1283470560


##########
jdbc/src/java/org/apache/hive/jdbc/saml/HiveJdbcBrowserClient.java:
##########
@@ -212,18 +213,19 @@ protected void openBrowserWindow() throws HiveJdbcBrowserException {
         LOG.info(
             "Desktop mode is not supported. Attempting to use OS "
                 + "commands to open the default browser");
+        String ssoUriStr = ssoUri.toString();

Review Comment:
   potential for NPE given we took out the null check above?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org