You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/01/20 18:10:32 UTC
[GitHub] [hive] vineetgarg02 commented on a change in pull request #1878: [DRAFT] Remove HiveSubQRemoveRelBuilder
vineetgarg02 commented on a change in pull request #1878:
URL: https://github.com/apache/hive/pull/1878#discussion_r561171053
##########
File path: ql/src/test/results/clientpositive/llap/subquery_in.q.out
##########
@@ -1805,22 +1833,38 @@ STAGE PLANS:
Filter Operator
predicate: _col1 is not null (type: boolean)
Statistics: Num rows: 13 Data size: 52 Basic stats: COMPLETE Column stats: COMPLETE
- Select Operator
- expressions: _col1 (type: int)
+ Group By Operator
+ keys: _col1 (type: int)
+ minReductionHashAggr: 0.53846157
+ mode: hash
outputColumnNames: _col0
- Statistics: Num rows: 13 Data size: 52 Basic stats: COMPLETE Column stats: COMPLETE
- Group By Operator
- keys: _col0 (type: int)
- minReductionHashAggr: 0.53846157
- mode: hash
- outputColumnNames: _col0
+ Statistics: Num rows: 6 Data size: 24 Basic stats: COMPLETE Column stats: COMPLETE
+ Reduce Output Operator
+ key expressions: _col0 (type: int)
+ null sort order: z
+ sort order: +
+ Map-reduce partition columns: _col0 (type: int)
Statistics: Num rows: 6 Data size: 24 Basic stats: COMPLETE Column stats: COMPLETE
- Reduce Output Operator
- key expressions: _col0 (type: int)
- null sort order: z
- sort order: +
- Map-reduce partition columns: _col0 (type: int)
- Statistics: Num rows: 6 Data size: 24 Basic stats: COMPLETE Column stats: COMPLETE
+ Reducer 4
+ Execution mode: vectorized, llap
Review comment:
Same as above: GBY is not being removed
##########
File path: ql/src/test/results/clientpositive/llap/subquery_in.q.out
##########
@@ -408,12 +408,18 @@ STAGE PLANS:
expressions: (UDFToDouble(_col0) / _col1) (type: double)
outputColumnNames: _col0
Statistics: Num rows: 1 Data size: 8 Basic stats: COMPLETE Column stats: COMPLETE
- Reduce Output Operator
- key expressions: _col0 (type: double)
- null sort order: z
- sort order: +
- Map-reduce partition columns: _col0 (type: double)
+ Group By Operator
Review comment:
This group by isn't being removed any more ( I guess due to INNER+GBY-> SEMI JOIN rule not triggering anymore).
May be open a jira/improvement to look into this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org