You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/06/06 08:01:58 UTC
[GitHub] [superset] yousoph commented on pull request #20095: fix(database): make to display validation error msg when all cases
yousoph commented on PR #20095:
URL: https://github.com/apache/superset/pull/20095#issuecomment-1147163356
@prosdev0107
this is looking good! Two small changes:
1. In the copy, let's put "See more" in quotes. The second sentence should start:
> Click "See more" for database-provided... etc etc
2. Can we move "See more" to the bottom of the error message? See the [design guidelines](https://github.com/apache/superset/wiki/Error-message-design-guidelines) for an example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org