You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2023/01/13 06:54:12 UTC

[GitHub] [flink] chenqin opened a new pull request, #21660: [FLINK-30658][Table SQL/Planner] remove table-planner direct dependency on flink-sql-parser-hive

chenqin opened a new pull request, #21660:
URL: https://github.com/apache/flink/pull/21660

   ## What is the purpose of the change
   
   To externalize Hive connector, we propose moving flink-sql-parser-hive into hive connector to maintain and release together. Given related class were code generated and less flexible to refactor, we propose adding a naive wrapper facade to proxy field or method calls in flink-sql-parser-hive.
   
   Once FLINK-30659 complete, we would remove flink-sql-parser-hive depdency completely from table-planner as related classed will be implemented in new flink-connector-hive-parent project.
   
   ## Brief change log
   - change  flink-sql-parser-hive in table-planner to provided, add flink-sql-parser-hive dependency to flink-connector-hive
   - add FlinkParserWrapper facade so that table-planner can build and run during flink-sql-parser-hive migration
   - adding FlinkParserWrapper unit tests
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   flink-connector-hive
   
   This change added tests and can be verified as follows:
   e2e tests should run
   flink-connector-hive test should pass
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21660: [FLINK-30658][Table SQL/Planner] remove table-planner direct dependency on flink-sql-parser-hive

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21660:
URL: https://github.com/apache/flink/pull/21660#issuecomment-1381392524

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6a0a07bc791cbfddf27be85c4a14eb794916f0d9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6a0a07bc791cbfddf27be85c4a14eb794916f0d9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6a0a07bc791cbfddf27be85c4a14eb794916f0d9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] chenqin closed pull request #21660: [FLINK-30658][Table SQL/Planner] remove table-planner direct dependency on flink-sql-parser-hive

Posted by GitBox <gi...@apache.org>.
chenqin closed pull request #21660: [FLINK-30658][Table SQL/Planner] remove table-planner direct dependency on flink-sql-parser-hive
URL: https://github.com/apache/flink/pull/21660


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] chenqin commented on pull request #21660: [FLINK-30658][Table SQL/Planner] remove table-planner direct dependency on flink-sql-parser-hive

Posted by GitBox <gi...@apache.org>.
chenqin commented on PR #21660:
URL: https://github.com/apache/flink/pull/21660#issuecomment-1381391658

   @luoyuxia @MartijnVisser please provide some feedback. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org