[GitHub] [nifi] Wastack commented on a change in pull request #4371: NIFI-7589 Fix path value when unpacking tar

[GitBox <gi...@apache.org>]

Wastack commented on a change in pull request #4371:
URL: https://github.com/apache/nifi/pull/4371#discussion_r450702073



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
##########
@@ -309,7 +309,10 @@ public void process(final InputStream in) throws IOException {
                             }
                             final File file = new File(tarEntry.getName());
                             final Path filePath = file.toPath();
-                            final String filePathString = filePath.getParent() + "/";
+                            String filePathString = "/";
+                            if(filePath.getParent() != null) {
+                                filePathString = filePath.getParent() + "/";

Review comment:
       Do you mean replacing e.g. "ham/egg/" with "/ham/egg"? Because that would change prior behavior of the "file.path" attribute. In that case, this behavior has to be changed in some other places too (e.g. all the other unpackers).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org