You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by Ruoxi Sun <za...@gmail.com> on 2024/01/08 09:38:02 UTC

[C++][Acero] Request for early review of PR on adding residual filter support to swiss join

Hi,

I'm taking the task [1] of adding residual filter support to swiss join of
acero and came up with this PR [2].

While this PR is currently in draft status, as I am working on adding more
specialized tests and benchmarks, all the fundamental code and comments are
complete, and it passes all existing tests. I believe it is a good time to
invite reviewers to conduct a preliminary review for disclosing any
potential major defect in terms of functional, performance and code
structure/style.

I greatly appreciate any early feedback, and am open to any necessary
discussions and revisions.

Thanks.

*Regards,*
*Rossi*

[1]: https://github.com/apache/arrow/issues/20339
[2]: https://github.com/apache/arrow/pull/39487

Re: [C++][Acero] Request for early review of PR on adding residual filter support to swiss join

Posted by Ruoxi Sun <za...@gmail.com>.
Great! Thank you Vibhatha, really appreciate it.

*Regards,*
*Rossi*


Vibhatha Abeykoon <vi...@gmail.com> 于2024年1月9日周二 14:46写道:

> Hi Ruoxi,
>
> I am taking a look at the PR, and will continue the discussion on Github.
>
> With Regards,
> Vibhatha Abeykoon
>

Re: [C++][Acero] Request for early review of PR on adding residual filter support to swiss join

Posted by Vibhatha Abeykoon <vi...@gmail.com>.
Hi Ruoxi,

I am taking a look at the PR, and will continue the discussion on Github.

With Regards,
Vibhatha Abeykoon