[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #3573: Client steering forced diversity

[GitBox <gi...@apache.org>]

rawlinp commented on a change in pull request #3573: Client steering forced diversity
URL: https://github.com/apache/trafficcontrol/pull/3573#discussion_r284439928
 
 

 ##########
 File path: traffic_router/core/src/test/resources/publish/CrStates
 ##########
 @@ -146,6 +149,30 @@
       "disabledLocations": [],
       "isAvailable": true
     },
+    "client-steering-diversity-test": {
 
 Review comment:
   I think the `disabledLocations` list is mostly just an optimization (an unnecessary one IMO but that's a different issue) for Traffic Monitor to tell Traffic Router that entire cachegroups are currently unavailable for a delivery service so that TR can eliminate those cachegroups from its "cache selection process". The CSD stuff isn't really changing that cache selection process since CSD is operating on the _result_ of that process to diversify the end result. So, I'm thinking that test case would add more coverage around the "cache selection process" but not really CSD per se.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services