You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/14 11:54:05 UTC
[GitHub] [flink] matriv opened a new pull request, #19472: [hotfix][build] Fix issue with scalafmt config file
matriv opened a new pull request, #19472:
URL: https://github.com/apache/flink/pull/19472
`.scalafmt.conf` resides on the root directory, so for the other
modules to find it we need to use the `rootDir` property which is
set by the `directory-maven-plugin`.
Previously, the `directory-maven-plugin` goal to set this property
was bound to `initialize` phase, and the `spotless:check` to `validate`
phase which comes before `initialize` and therefore the `rootDir`
property was not available.
Bind the `directory-maven-plugin` goal to `validate` which is the 1st
phase in the maven lifycycle, and bind `spotless:check` to the
`process-sources` phase which anyway makes more sense. This way users
can run `mvn test, mvn clean install, mvn verify`, etc. from within any
module and still be able to run also the bound `spotless:check` goal.
This way, the only downside of introducing the `scalafmt` is that if a
user wants to run `spotless:check/spotless:apply` autonomously inside
any module, he/she just needs to prefix it with the `validate` goal
which sets the `rootDir` property, i.e.:
`flink/flink-table/flink-table-planner$ mvn validate spotless:apply`
Follows: 3ea3fee5ac996f6ae8836c3cba252f974d20bd2e
Follows: #19025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on pull request #19472: [hotfix][build] Fix issue with scalafmt config file
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on PR #19472:
URL: https://github.com/apache/flink/pull/19472#issuecomment-1099119618
Does `mvn validate spotless:apply` works in the root as well? If that's the case, I think it's a good solution! Thank you for looking at this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol closed pull request #19472: [hotfix][build] Fix issue with scalafmt config file
Posted by GitBox <gi...@apache.org>.
zentol closed pull request #19472: [hotfix][build] Fix issue with scalafmt config file
URL: https://github.com/apache/flink/pull/19472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19472: [hotfix][build] Fix issue with scalafmt config file
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19472:
URL: https://github.com/apache/flink/pull/19472#issuecomment-1099113817
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4be35a8d7a8f622df560778969bdafb3cea3e931",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4be35a8d7a8f622df560778969bdafb3cea3e931",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4be35a8d7a8f622df560778969bdafb3cea3e931 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #19472: [hotfix][build] Fix issue with scalafmt config file
Posted by GitBox <gi...@apache.org>.
matriv commented on PR #19472:
URL: https://github.com/apache/flink/pull/19472#issuecomment-1099207362
@slinkydeveloper it does, @zentol followed the "brute force" approach to define the directory on every module needed: https://github.com/apache/flink/pull/19474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #19472: [hotfix][build] Fix issue with scalafmt config file
Posted by GitBox <gi...@apache.org>.
zentol commented on PR #19472:
URL: https://github.com/apache/flink/pull/19472#issuecomment-1102805805
Closing in favor of #19474.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org