[GitHub] [pulsar] gaoran10 commented on a change in pull request #14044: [broker][authentication]Support pass http auth status

[GitBox <gi...@apache.org>]

gaoran10 commented on a change in pull request #14044:
URL: https://github.com/apache/pulsar/pull/14044#discussion_r800321860



##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/FunctionApiResource.java
##########
@@ -54,7 +54,7 @@ public String clientAppId() {
                 : null;
     }
 
-    public AuthenticationDataHttps clientAuthData() {
-        return (AuthenticationDataHttps) httpRequest.getAttribute(AuthenticationFilter.AuthenticatedDataAttributeName);
+    public AuthenticationDataSource clientAuthData() {
+        return (AuthenticationDataSource) httpRequest.getAttribute(AuthenticationFilter.AuthenticatedDataAttributeName);

Review comment:
       If the return type change to the interface `AuthenticationDataSource`, it indicates the return value will be different implementations. But it seems that the implementation of the interface `AuthenticationDataSource` here will always be `AuthenticationDataHttps`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org