You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/05/22 23:25:46 UTC
Review Request 34613: Added and implemented 'update()' API call to
Sorter.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34613/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Niklas Nielsen.
Bugs: MESOS-2729
https://issues.apache.org/jira/browse/MESOS-2729
Repository: mesos
Description
-------
Need this for the subsequent review.
Diffs
-----
src/master/allocator/sorter/drf/sorter.hpp fd00c8ccd6ac352113ae5b2d69b2d355ba32cc8d
src/master/allocator/sorter/drf/sorter.cpp f53a934b2964f9da70b1f5624916373f1f82bbec
src/master/allocator/sorter/sorter.hpp f06b9462f206168999318363fc46784c2e41b19c
src/tests/sorter_tests.cpp 6b0389bb17293d79ccb821c619127935a77c96cc
Diff: https://reviews.apache.org/r/34613/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 34613: Added and implemented 'update()' API call to
Sorter.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34613/#review85006
-----------------------------------------------------------
Ship it!
src/master/allocator/sorter/drf/sorter.cpp
<https://reviews.apache.org/r/34613/#comment136485>
Could you please add this CHECK to 'remove' as well just to be consistent.
src/tests/sorter_tests.cpp
<https://reviews.apache.org/r/34613/#comment136486>
s/Update/UpdateSlaveTotal/?
- Jie Yu
On May 22, 2015, 9:25 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34613/
> -----------------------------------------------------------
>
> (Updated May 22, 2015, 9:25 p.m.)
>
>
> Review request for mesos, Jie Yu and Niklas Nielsen.
>
>
> Bugs: MESOS-2729
> https://issues.apache.org/jira/browse/MESOS-2729
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Need this for the subsequent review.
>
>
> Diffs
> -----
>
> src/master/allocator/sorter/drf/sorter.hpp fd00c8ccd6ac352113ae5b2d69b2d355ba32cc8d
> src/master/allocator/sorter/drf/sorter.cpp f53a934b2964f9da70b1f5624916373f1f82bbec
> src/master/allocator/sorter/sorter.hpp f06b9462f206168999318363fc46784c2e41b19c
> src/tests/sorter_tests.cpp 6b0389bb17293d79ccb821c619127935a77c96cc
>
> Diff: https://reviews.apache.org/r/34613/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>