[GitHub] [incubator-kyuubi] simon824 commented on a change in pull request #1200: [KYUUBI #1190] Enhance error log detection

[GitBox <gi...@apache.org>]

simon824 commented on a change in pull request #1200:
URL: https://github.com/apache/incubator-kyuubi/pull/1200#discussion_r725440813



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala
##########
@@ -121,7 +121,8 @@ trait ProcBuilder {
               error = KyuubiSQLException(sb.toString() + s"\n See more: $engineLog")
               line = reader.readLine()
               while (sb.length < maxErrorSize && line != null &&
-                (line.startsWith("\tat ") || line.startsWith("Caused by: "))) {
+                (containsIgnoreCase(line, "Exception:") ||

Review comment:
       Ok，and Line 118 use `containsIgnoreCase` too, does it need to be changed to `contains` here?
   ```
               if (containsIgnoreCase(line, "Exception:") &&
                 !line.contains("at ") && !line.startsWith("Caused by:")) {
                 val sb = new StringBuilder(line)
                 error = KyuubiSQLException(sb.toString() + s"\n See more: $engineLog")
                 line = reader.readLine()
                 while (sb.length < maxErrorSize && line != null &&
                   (containsIgnoreCase(line, "Exception:") ||
                     line.startsWith("\tat ") ||
                     line.startsWith("Caused by: "))) {
                   sb.append("\n" + line)
                   line = reader.readLine()
                 }
   
                 error = KyuubiSQLException(sb.toString() + s"\n See more: $engineLog")
               }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org