You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/12/04 06:20:08 UTC

[PR] [SPARK-46234][PYTHON] Introduce `PySparkKeyError` for PySpark error framework [spark]

itholic opened a new pull request, #44151:
URL: https://github.com/apache/spark/pull/44151

   ### What changes were proposed in this pull request?
   
   This PR proposes to introduce `PySparkKeyError` for error framework, and migrate Python built-in `KeyError` into `PySparkKeyError`.
   
   ### Why are the changes needed?
   
   For better error handling.
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   No API changes, but it's improve the user-facing error messages.
   
   ### How was this patch tested?
   
   The existing CI should pass
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46234][PYTHON] Introduce `PySparkKeyError` for PySpark error framework [spark]

Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #44151:
URL: https://github.com/apache/spark/pull/44151#issuecomment-1837913433

   Thanks @HyukjinKwon and @dongjoon-hyun for the review on recent series of PySpark error framework related PRs.
   
   This would be the last one for migrating non-PySpark errors from `pyspark/sql/*`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46234][PYTHON] Introduce `PySparkKeyError` for PySpark error framework [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #44151: [SPARK-46234][PYTHON] Introduce `PySparkKeyError` for PySpark error framework
URL: https://github.com/apache/spark/pull/44151


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46234][PYTHON] Introduce `PySparkKeyError` for PySpark error framework [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #44151:
URL: https://github.com/apache/spark/pull/44151#issuecomment-1838270153

   LGTM, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org