You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/09/26 10:38:14 UTC
[GitHub] [rocketmq] Cczzzz opened a new issue #3381: BUG , when role change but not register again
Cczzzz opened a new issue #3381:
URL: https://github.com/apache/rocketmq/issues/3381
I run rocket with
#版本号的方式注册
forceRegister=false
#预先设定好的leader
preferredLeaderId=n0
if i kill the master and leader， n0 will become again leader.
n0's brokerId = 1,not 0.
Because role change will not register again
BrokerOuterAPI # 281 ，only compare topicConfigWrapper.getDataVersion.
switch (response.getCode()) {
case ResponseCode.SUCCESS: {
QueryDataVersionResponseHeader queryDataVersionResponseHeader =
(QueryDataVersionResponseHeader) response.decodeCommandCustomHeader(QueryDataVersionResponseHeader.class);
changed = queryDataVersionResponseHeader.getChanged();
byte[] body = response.getBody();
if (body != null) {
nameServerDataVersion = DataVersion.decode(body, DataVersion.class);
if (!topicConfigWrapper.getDataVersion().equals(nameServerDataVersion)) {
changed = true;
}
}
if (changed == null || changed) {
changedList.add(Boolean.TRUE);
}
}
default:
break;
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on issue #3381: BUG , when role change but not register again
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #3381:
URL: https://github.com/apache/rocketmq/issues/3381#issuecomment-958678386
Merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on issue #3381: BUG , when role change but not register again
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #3381:
URL: https://github.com/apache/rocketmq/issues/3381#issuecomment-958678386
Merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on issue #3381: BUG , when role change but not register again
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #3381:
URL: https://github.com/apache/rocketmq/issues/3381#issuecomment-958678386
Merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin closed issue #3381: BUG , when role change but not register again
Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #3381:
URL: https://github.com/apache/rocketmq/issues/3381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on issue #3381: BUG , when role change but not register again
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #3381:
URL: https://github.com/apache/rocketmq/issues/3381#issuecomment-929782734
Good catch, I think forceRegister should be forced to true in here. Could you submit a pull request to fix it？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on issue #3381: BUG , when role change but not register again
Posted by GitBox <gi...@apache.org>.
Cczzzz commented on issue #3381:
URL: https://github.com/apache/rocketmq/issues/3381#issuecomment-930110831
Maybe the version number should be increased when role change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin closed issue #3381: BUG , when role change but not register again
Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #3381:
URL: https://github.com/apache/rocketmq/issues/3381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on issue #3381: BUG , when role change but not register again
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #3381:
URL: https://github.com/apache/rocketmq/issues/3381#issuecomment-958678386
Merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on issue #3381: BUG , when role change but not register again
Posted by GitBox <gi...@apache.org>.
Cczzzz commented on issue #3381:
URL: https://github.com/apache/rocketmq/issues/3381#issuecomment-930110831
Maybe the version number should be increased when role change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on issue #3381: BUG , when role change but not register again
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #3381:
URL: https://github.com/apache/rocketmq/issues/3381#issuecomment-929782734
Good catch, I think forceRegister should be forced to true in here. Could you submit a pull request to fix it？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin closed issue #3381: BUG , when role change but not register again
Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #3381:
URL: https://github.com/apache/rocketmq/issues/3381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin closed issue #3381: BUG , when role change but not register again
Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #3381:
URL: https://github.com/apache/rocketmq/issues/3381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org