You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/29 11:47:27 UTC
[GitHub] [camel-website] psingh587 opened a new pull request #288: scrollbar
visibilty issues in nav-container
psingh587 opened a new pull request #288: scrollbar visibilty issues in nav-container
URL: https://github.com/apache/camel-website/pull/288
-From my personal experience, I feel the scroll-bar in nav-container is very light. It sometimes is not even visible and also the width is pretty small which makes it less clickable.
Before Changes:-
After changes:-
#Also it changes color on hovering. I have made the hover color a bit darker than the scrollbar-color
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on a change in pull request
#288: scrollbar visibilty issues in nav-container
Posted by GitBox <gi...@apache.org>.
psingh587 commented on a change in pull request #288: scrollbar visibilty issues in nav-container
URL: https://github.com/apache/camel-website/pull/288#discussion_r401481059
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -6,6 +6,7 @@
--color-smoke-50: #f5f5f5;
--color-smoke-70: #f0f0f0;
--color-smoke-90: #e1e1e1;
+ --color-smoke-100: #e3dcdc;
Review comment:
I was looking for a darker shade so that it is visible even in the brightest screens. I guess --color-smoke-90 would work too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#288: scrollbar visibilty issues in nav-container
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #288: scrollbar visibilty issues in nav-container
URL: https://github.com/apache/camel-website/pull/288#discussion_r400461059
##########
File path: antora-ui-camel/src/css/nav.css
##########
@@ -89,11 +89,15 @@ html.is-clipped--nav {
}
.nav-panel-menu::-webkit-scrollbar {
- width: 0.25rem;
+ width: 0.29rem;
}
.nav-panel-menu::-webkit-scrollbar-thumb {
- background-color: var(--nav-border-color);
+ background-color: #e3dcdc;
+}
+
+.nav-panel-menu::-webkit-scrollbar-thumb:hover {
+ background-color: #afa7a7;
Review comment:
Use a variable here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on a change in pull request
#288: scrollbar visibilty issues in nav-container
Posted by GitBox <gi...@apache.org>.
psingh587 commented on a change in pull request #288: scrollbar visibilty issues in nav-container
URL: https://github.com/apache/camel-website/pull/288#discussion_r401481059
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -6,6 +6,7 @@
--color-smoke-50: #f5f5f5;
--color-smoke-70: #f0f0f0;
--color-smoke-90: #e1e1e1;
+ --color-smoke-100: #e3dcdc;
Review comment:
I was looking for a darker shade so that it is visible even in the brightest screens. I guess --colot-smoke-90 would work too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #288: scrollbar
visibilty issues in nav-container
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #288: scrollbar visibilty issues in nav-container
URL: https://github.com/apache/camel-website/pull/288#issuecomment-607177444
> Needs some improvement.
Made the changes @zregvart
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #288: scrollbar
visibilty issues in nav-container
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #288: scrollbar visibilty issues in nav-container
URL: https://github.com/apache/camel-website/pull/288#issuecomment-606561083
@zregvart Made the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart merged pull request #288: scrollbar
visibilty issues in nav-container
Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #288: scrollbar visibilty issues in nav-container
URL: https://github.com/apache/camel-website/pull/288
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #288: scrollbar
visibilty issues in nav-container
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #288: scrollbar visibilty issues in nav-container
URL: https://github.com/apache/camel-website/pull/288#issuecomment-607245470
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#288: scrollbar visibilty issues in nav-container
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #288: scrollbar visibilty issues in nav-container
URL: https://github.com/apache/camel-website/pull/288#discussion_r401458581
##########
File path: antora-ui-camel/src/css/vars.css
##########
@@ -6,6 +6,7 @@
--color-smoke-50: #f5f5f5;
--color-smoke-70: #f0f0f0;
--color-smoke-90: #e1e1e1;
+ --color-smoke-100: #e3dcdc;
Review comment:
Why introduce yet another color, could we not use `--color-smoke-90`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on a change in pull request
#288: scrollbar visibilty issues in nav-container
Posted by GitBox <gi...@apache.org>.
psingh587 commented on a change in pull request #288: scrollbar visibilty issues in nav-container
URL: https://github.com/apache/camel-website/pull/288#discussion_r401477986
##########
File path: antora-ui-camel/src/img/close-outline.svg
##########
@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"><g data-name="Layer 2"><g data-name="close"><rect width="24" height="24" transform="rotate(180 12 12)" opacity="0"/><path d="M13.41 12l4.3-4.29a1 1 0 1 0-1.42-1.42L12 10.59l-4.29-4.3a1 1 0 0 0-1.42 1.42l4.3 4.29-4.3 4.29a1 1 0 0 0 0 1.42 1 1 0 0 0 1.42 0l4.29-4.3 4.29 4.3a1 1 0 0 0 1.42 0 1 1 0 0 0 0-1.42z"/></g></g></svg>
Review comment:
Yeah I have already removed this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#288: scrollbar visibilty issues in nav-container
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #288: scrollbar visibilty issues in nav-container
URL: https://github.com/apache/camel-website/pull/288#discussion_r401458899
##########
File path: antora-ui-camel/src/img/close-outline.svg
##########
@@ -0,0 +1 @@
+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"><g data-name="Layer 2"><g data-name="close"><rect width="24" height="24" transform="rotate(180 12 12)" opacity="0"/><path d="M13.41 12l4.3-4.29a1 1 0 1 0-1.42-1.42L12 10.59l-4.29-4.3a1 1 0 0 0-1.42 1.42l4.3 4.29-4.3 4.29a1 1 0 0 0 0 1.42 1 1 0 0 0 1.42 0l4.29-4.3 4.29 4.3a1 1 0 0 0 1.42 0 1 1 0 0 0 0-1.42z"/></g></g></svg>
Review comment:
Unrelated change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#288: scrollbar visibilty issues in nav-container
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #288: scrollbar visibilty issues in nav-container
URL: https://github.com/apache/camel-website/pull/288#discussion_r400460967
##########
File path: antora-ui-camel/src/css/nav.css
##########
@@ -89,11 +89,15 @@ html.is-clipped--nav {
}
.nav-panel-menu::-webkit-scrollbar {
- width: 0.25rem;
+ width: 0.29rem;
}
.nav-panel-menu::-webkit-scrollbar-thumb {
- background-color: var(--nav-border-color);
+ background-color: #e3dcdc;
Review comment:
Change the variable value, don't hard code values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services