You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/21 09:33:41 UTC
[GitHub] [pulsar] eolivelli opened a new pull request #10302: Release procedure: fix paths for docker-build-deb.sh and docker-build-rpm.sh
eolivelli opened a new pull request #10302:
URL: https://github.com/apache/pulsar/pull/10302
### Motivation
While preparing the release for Pulsar 2.7.2 I had a problem executing docker-build-rpm.sh and docker-build-deb.sh on MacOS.
It looks like the reference to the Pulsar main directory is wrong and we are mounting the wrong directory while launching docker.
### Modifications
Use "realpath" in order to get the right directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #10302: Release procedure: fix paths for docker-build-deb.sh and docker-build-rpm.sh
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #10302:
URL: https://github.com/apache/pulsar/pull/10302#discussion_r617373115
##########
File path: pulsar-client-cpp/pkg/rpm/docker-build-rpm.sh
##########
@@ -20,7 +20,8 @@
set -e
-ROOT_DIR=$(dirname $0)/../../../..
+ROOT_DIR=$(dirname $0)/../../..
+ROOT_DIR=$(realpath $ROOT_DIR)
Review comment:
replace with this line (same fix as made in previous comment)
```
ROOT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )"/../../.. &> /dev/null && pwd )"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10302: Release procedure: fix paths for docker-build-deb.sh and docker-build-rpm.sh
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10302:
URL: https://github.com/apache/pulsar/pull/10302#issuecomment-823935669
@lhotari thanks for your quick feedback, I have updated the patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #10302: Release procedure: fix paths for docker-build-deb.sh and docker-build-rpm.sh
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #10302:
URL: https://github.com/apache/pulsar/pull/10302#discussion_r617375766
##########
File path: pulsar-client-cpp/pkg/deb/docker-build-deb.sh
##########
@@ -21,6 +21,7 @@
set -e
ROOT_DIR=$(dirname $0)/../../..
+ROOT_DIR=$(realpath $ROOT_DIR)
Review comment:
it looks odd, but it works and takes all possible corner cases into account. It's the most popular answer for this problem in Stackoverflow: https://stackoverflow.com/a/246128 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #10302: Release procedure: fix paths for docker-build-deb.sh and docker-build-rpm.sh
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #10302:
URL: https://github.com/apache/pulsar/pull/10302#discussion_r617376816
##########
File path: pulsar-client-cpp/pkg/deb/docker-build-deb.sh
##########
@@ -21,6 +21,7 @@
set -e
ROOT_DIR=$(dirname $0)/../../..
+ROOT_DIR=$(realpath $ROOT_DIR)
Review comment:
good. fixed. thanks
it works
##########
File path: pulsar-client-cpp/pkg/rpm/docker-build-rpm.sh
##########
@@ -20,7 +20,8 @@
set -e
-ROOT_DIR=$(dirname $0)/../../../..
+ROOT_DIR=$(dirname $0)/../../..
+ROOT_DIR=$(realpath $ROOT_DIR)
Review comment:
good. fixed. thanks
it works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10302: Release procedure: fix paths for docker-build-deb.sh and docker-build-rpm.sh
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10302:
URL: https://github.com/apache/pulsar/pull/10302#issuecomment-823927588
the problem is present both on Linux and on Mac
this is the error on Linux for instance
```
ubuntu@ip-10-101-34-25:~/pulsar$ pulsar-client-cpp/pkg/rpm/docker-build-rpm.sh
centos-7: Pulling from apachepulsar/pulsar-build
75f829a71a1c: Pull complete
7f1950a3bdcc: Pull complete
9cfa2ce01706: Pull complete
51b39bd58273: Pull complete
4dbd101d2ed0: Pull complete
201ee21c9b24: Pull complete
5c044d9e97bd: Pull complete
108dc2b19e5e: Pull complete
cc981b243b9b: Pull complete
561ee64b42eb: Pull complete
9d3addb8f95e: Pull complete
Digest: sha256:5c90d7a1f30f603a049cf53dc04f730c989be9bf5eeb537ec20fc874d58f74cd
Status: Downloaded newer image for apachepulsar/pulsar-build:centos-7
docker: Error response from daemon: create pulsar-client-cpp/pkg/rpm/../../../..: "pulsar-client-cpp/pkg/rpm/../../../.." includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #10302: Release procedure: fix paths for docker-build-deb.sh and docker-build-rpm.sh
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #10302:
URL: https://github.com/apache/pulsar/pull/10302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #10302: Release procedure: fix paths for docker-build-deb.sh and docker-build-rpm.sh
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #10302:
URL: https://github.com/apache/pulsar/pull/10302#discussion_r617375766
##########
File path: pulsar-client-cpp/pkg/deb/docker-build-deb.sh
##########
@@ -21,6 +21,7 @@
set -e
ROOT_DIR=$(dirname $0)/../../..
+ROOT_DIR=$(realpath $ROOT_DIR)
Review comment:
it looks odd, but it works and takes all possible corner cases into account. It's one most popular answer for this problem in Stackoverflow: https://stackoverflow.com/a/246128 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #10302: Release procedure: fix paths for docker-build-deb.sh and docker-build-rpm.sh
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #10302:
URL: https://github.com/apache/pulsar/pull/10302#discussion_r617370696
##########
File path: pulsar-client-cpp/pkg/deb/docker-build-deb.sh
##########
@@ -21,6 +21,7 @@
set -e
ROOT_DIR=$(dirname $0)/../../..
+ROOT_DIR=$(realpath $ROOT_DIR)
Review comment:
I'd recommend replacing the 2 lines starting with "ROOT_DIR=" with this line to determine the ROOT_DIR
```
ROOT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )"/../../.. &> /dev/null && pwd )"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org