You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/24 05:27:20 UTC

[GitHub] [arrow] cyb70289 commented on pull request #13222: MINOR: [C++] Move static declaration to non-static declaration to improve performance

cyb70289 commented on PR #13222:
URL: https://github.com/apache/arrow/pull/13222#issuecomment-1135425796

   appveyor test failure may deserve deeper investigation, though unlikely related to this pr:
   https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/43639301/job/n3qanqaqw8xdrcij#L2236
   ```
   23/94 Test #23: arrow-threading-utility-test ..............***Failed   27.32 sec
   Running main() from D:\bld\gtest_1647154904782\work\googletest\src\gtest_main.cc
   [==========] Running 140 tests from 24 test suites.
   [----------] Global test environment set-up.
   [----------] 7 tests from CancelTest
   [ RUN      ] CancelTest.StopBasics
   [       OK ] CancelTest.StopBasics (0 ms)
   [ RUN      ] CancelTest.StopTokenCopy
   [       OK ] CancelTest.StopTokenCopy (0 ms)
   [ RUN      ] CancelTest.RequestStopTwice
   [       OK ] CancelTest.RequestStopTwice (0 ms)
   [ RUN      ] CancelTest.Unstoppable
   [       OK ] CancelTest.Unstoppable (0 ms)
   [ RUN      ] CancelTest.SourceVanishes
   [       OK ] CancelTest.SourceVanishes (0 ms)
   [ RUN      ] CancelTest.ThreadedPollSuccess
   [       OK ] CancelTest.ThreadedPollSuccess (8332 ms)
   [ RUN      ] CancelTest.ThreadedPollCancel
   [       OK ] CancelTest.ThreadedPollCancel (7768 ms)
   [----------] 7 tests from CancelTest (16100 ms total)
   [----------] 2 tests from SignalCancelTest
   [ RUN      ] SignalCancelTest.Register
   [       OK ] SignalCancelTest.Register (0 ms)
   [ RUN      ] SignalCancelTest.RegisterUnregister
   C:/projects/arrow/cpp/src/arrow/util/cancel_test.cc(191): error: Value of: stop_token_->IsStopRequested()
     Actual: true
   Expected: false
   C:/projects/arrow/cpp/src/arrow/util/cancel_test.cc(191): error: Value of: stop_token_->IsStopRequested()
     Actual: true
   Expected: false
   [  FAILED  ] SignalCancelTest.RegisterUnregister (22 ms)
   [----------] 2 tests from SignalCancelTest (22 ms total)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org