You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/18 07:35:37 UTC

[GitHub] [arrow] mrkn opened a new pull request #9524: ARROW-11686: [C++] Call ArrowLog::InstallFailureSignalHandler to show stack trace

mrkn opened a new pull request #9524:
URL: https://github.com/apache/arrow/pull/9524


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mrkn commented on pull request #9524: ARROW-11686: [C++] Call ArrowLog::InstallFailureSignalHandler to show stack trace

Posted by GitBox <gi...@apache.org>.
mrkn commented on pull request #9524:
URL: https://github.com/apache/arrow/pull/9524#issuecomment-781237472


   Oops!  I'm sorry I thought I checked it but I couldn't do that due to the wrong cmake configuration.  I'il fix it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] lidavidm closed pull request #9524: ARROW-11686: [C++] Call ArrowLog::InstallFailureSignalHandler to show stack trace

Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #9524:
URL: https://github.com/apache/arrow/pull/9524


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pitrou commented on pull request #9524: ARROW-11686: [C++] Call ArrowLog::InstallFailureSignalHandler to show stack trace

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9524:
URL: https://github.com/apache/arrow/pull/9524#issuecomment-781298454


   Note that it only seems to change something if GLog is enabled?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9524: ARROW-11686: [C++] Call ArrowLog::InstallFailureSignalHandler to show stack trace

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9524:
URL: https://github.com/apache/arrow/pull/9524#issuecomment-781122466


   https://issues.apache.org/jira/browse/ARROW-11686


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mrkn commented on pull request #9524: ARROW-11686: [C++] Call ArrowLog::InstallFailureSignalHandler to show stack trace

Posted by GitBox <gi...@apache.org>.
mrkn commented on pull request #9524:
URL: https://github.com/apache/arrow/pull/9524#issuecomment-781300856


   Yes, it does. InstallFailureSignalHandler and UninstallSingalAction are empty functions if Glog is disabled.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] mrkn commented on pull request #9524: ARROW-11686: [C++] Call ArrowLog::InstallFailureSignalHandler to show stack trace

Posted by GitBox <gi...@apache.org>.
mrkn commented on pull request #9524:
URL: https://github.com/apache/arrow/pull/9524#issuecomment-781278984


   @pitrou The compiling issue was resolved.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pitrou commented on pull request #9524: ARROW-11686: [C++] Call ArrowLog::InstallFailureSignalHandler to show stack trace

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9524:
URL: https://github.com/apache/arrow/pull/9524#issuecomment-781219996


   @mrkn This doesn't seem to compile (see failed CI build). Can you take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org