[jira] [Created] (PIG-3087) Refactor TestLogicalPlanBuilder to be meaningful

["Jonathan Coveney (JIRA)" <ji...@apache.org>]

Jonathan Coveney created PIG-3087:
-------------------------------------

             Summary: Refactor TestLogicalPlanBuilder to be meaningful
                 Key: PIG-3087
                 URL: https://issues.apache.org/jira/browse/PIG-3087
             Project: Pig
          Issue Type: Bug
            Reporter: Jonathan Coveney
             Fix For: 0.12
         Attachments: PIG-3087-0.patch

I started doing this as part of another patch, but there are some bigger issues, and I don't have the time to dig in atm.

That said, a lot of the tests as written don't test anything. I used more modern junit patterns, and discovered we had a lot of tests that weren't functioning properly. Making them function properly unveiled that the general buildLp pattern doesn't work properly anymore for many cases where it would throw an error in grunt, but for whatever reason no error is thrown in the tests.

Any test with _1 is a test that previous failed, that now doesn't. Some, however, don't make sense so I think what really needs to be done is figure out which should be failing, which shouldn't, and then fix buildLp accordingly.

I will attach my pass at it, but it is incomplete and needs work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira