Re: [PR] kie-issues#1941/kie-issues#1921: Simplify enveloped components and add Process Definitions to the Management Console [incubator-kie-tools]

["tiagobento (via GitHub)" <gi...@apache.org>]

tiagobento commented on code in PR #3090:
URL: https://github.com/apache/incubator-kie-tools/pull/3090#discussion_r2072198344


##########
packages/runtime-tools-management-console-webapp/dev-webapp/unsecured-runtime/pom.xml:
##########
@@ -32,7 +32,20 @@
 
   <!-- This is a development app. It's better that we use an arbitrary string to not make this more complicated than it has to be. -->
   <artifactId>management-console-dev-webapp-runtime</artifactId>
-  <version>999-dev</version>
+  <name>KIE Tools :: Management Console Web App :: Unsecured Runtime</name>
+  <version>${revision}</version>

Review Comment:
   I think this version shouldn't be aligned with the repo's version at all? I mean I don't want this package to give the wrong idea about what it is... What's why I initially left the obviously dev-only version of `999-dev`? What's your reasoning for changing it? Thank you!



##########
packages/webpack-base/webpack.common.config.js:
##########
@@ -57,7 +57,7 @@ module.exports = (webpackEnv) => {
       ]
     : [];
 
-  const importsNotUsedAsValues = live ? { importsNotUsedAsValues: "preserve" } : {};
+  const verbatimModuleSyntax = live ? { verbatimModuleSyntax: "preserve" } : {};

Review Comment:
   Maybe adding a nice comment here for us in the future? 😅 



##########
packages/runtime-tools-management-console-webapp/dev-webapp/unsecured-runtime/pom.xml:
##########
@@ -113,6 +126,22 @@
       <groupId>org.kie</groupId>
       <artifactId>kogito-addons-quarkus-data-audit</artifactId>
     </dependency>
+
+    <!-- DevUI -->
+    <dependency>
+      <groupId>org.jbpm</groupId>
+      <artifactId>jbpm-quarkus-devui</artifactId>
+    </dependency>

Review Comment:
   Need to add `jbpm-quarkus-devui` as a devDependency in this package if you wanna use it here.



##########
packages/webpack-base/package.json:
##########
@@ -17,6 +17,8 @@
     "."
   ],
   "devDependencies": {
+    "@babel/generator": "^7.26.5",
+    "@babel/parser": "^7.26.5",

Review Comment:
   Why?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org