You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/11 14:38:39 UTC
[GitHub] [inlong] fuweng11 opened a new pull request, #5500: [INLONG-5499][Manager] Fix the problem of data source is successfully configured, and the status is always issued and added
fuweng11 opened a new pull request, #5500:
URL: https://github.com/apache/inlong/pull/5500
### Prepare a Pull Request
- Fixes #5499
### Motivation
Make sure after receiving the command from the agent, the data source will change to normal state
### Modifications
After updating the data source status, return to version correctly
### Verifying this change
*(Please pick either of the following options)*
- [X] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5500: [INLONG-5499][Manager] Fix the status of the data source was wrong
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5500:
URL: https://github.com/apache/inlong/pull/5500#discussion_r944064566
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AgentServiceImpl.java:
##########
@@ -192,6 +192,7 @@ private List<DataConfig> fetchNonFileTasks(TaskRequest taskRequest) {
sourceEntity.setAgentIp(taskRequest.getAgentIp());
sourceEntity.setUuid(taskRequest.getUuid());
if (sourceMapper.updateByPrimaryKeySelective(sourceEntity) == 1) {
+ sourceEntity.setVersion(sourceEntity.getVersion() + 1);
Review Comment:
OK👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on a diff in pull request #5500: [INLONG-5499][Manager] Fix the status of the data source was wrong
Posted by GitBox <gi...@apache.org>.
fuweng11 commented on code in PR #5500:
URL: https://github.com/apache/inlong/pull/5500#discussion_r944062804
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AgentServiceImpl.java:
##########
@@ -192,6 +192,7 @@ private List<DataConfig> fetchNonFileTasks(TaskRequest taskRequest) {
sourceEntity.setAgentIp(taskRequest.getAgentIp());
sourceEntity.setUuid(taskRequest.getUuid());
if (sourceMapper.updateByPrimaryKeySelective(sourceEntity) == 1) {
+ sourceEntity.setVersion(sourceEntity.getVersion() + 1);
Review Comment:
Cannot proceed` ++sourceEntity.getVersion(`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5500: [INLONG-5499][Manager] Fix the problem of data source is successfully configured, and the status is always issued and added
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5500:
URL: https://github.com/apache/inlong/pull/5500#discussion_r944059940
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AgentServiceImpl.java:
##########
@@ -192,6 +192,7 @@ private List<DataConfig> fetchNonFileTasks(TaskRequest taskRequest) {
sourceEntity.setAgentIp(taskRequest.getAgentIp());
sourceEntity.setUuid(taskRequest.getUuid());
if (sourceMapper.updateByPrimaryKeySelective(sourceEntity) == 1) {
+ sourceEntity.setVersion(sourceEntity.getVersion() + 1);
Review Comment:
Suggest changing to `++sourceEntity.getVersion()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] fuweng11 commented on a diff in pull request #5500: [INLONG-5499][Manager] Fix the status of the data source was wrong
Posted by GitBox <gi...@apache.org>.
fuweng11 commented on code in PR #5500:
URL: https://github.com/apache/inlong/pull/5500#discussion_r944062804
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AgentServiceImpl.java:
##########
@@ -192,6 +192,7 @@ private List<DataConfig> fetchNonFileTasks(TaskRequest taskRequest) {
sourceEntity.setAgentIp(taskRequest.getAgentIp());
sourceEntity.setUuid(taskRequest.getUuid());
if (sourceMapper.updateByPrimaryKeySelective(sourceEntity) == 1) {
+ sourceEntity.setVersion(sourceEntity.getVersion() + 1);
Review Comment:
Integer type cannot proceed` ++sourceEntity.getVersion(`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5500: [INLONG-5499][Manager] Fix the status of the data source was wrong
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5500:
URL: https://github.com/apache/inlong/pull/5500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org