You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/01 19:48:53 UTC

[GitHub] [arrow] lafiona commented on a change in pull request #12489: ARROW-15692: [Dev] Update release scripts to use default branch

lafiona commented on a change in pull request #12489:
URL: https://github.com/apache/arrow/pull/12489#discussion_r817090304



##########
File path: dev/release/post-05-ruby.sh
##########
@@ -32,14 +32,16 @@ version=$1
 archive_name=apache-arrow-${version}
 tar_gz=${archive_name}.tar.gz
 
+source "${SOURCE_DIR}/git-vars.sh"
+
 echo "NOTE: We should release RubyGems after Homebrew and MSYS2 packages are updated!!!"
 
 echo "Checking Homebrew package..."
 homebrew_version=$(
   curl \
     --fail \
     --no-progress-meter \
-    https://raw.githubusercontent.com/Homebrew/homebrew-core/master/Formula/apache-arrow-glib.rb | \
+    https://raw.githubusercontent.com/Homebrew/homebrew-core/${DEFAULT_BRANCH}/Formula/apache-arrow-glib.rb | \

Review comment:
       Thank you, @nealrichardson, this makes sense to me. I'll also revert the change to source `git-vars.sh` in this file. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org