You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by jo...@apache.org on 2020/04/28 18:31:18 UTC

[royale-asjs] branch develop updated: RoyaleUnit: add more useful error if reflection doesn't property return [BeforeClass] and [AfterClass] methods

This is an automated email from the ASF dual-hosted git repository.

joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 03792b8  RoyaleUnit: add more useful error if reflection doesn't property return [BeforeClass] and [AfterClass] methods
03792b8 is described below

commit 03792b83b7e231795f47843d03a6e07fede2a9b3
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Tue Apr 28 11:31:18 2020 -0700

    RoyaleUnit: add more useful error if reflection doesn't property return [BeforeClass] and [AfterClass] methods
---
 .../main/royale/org/apache/royale/test/runners/MetadataRunner.as  | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/frameworks/projects/RoyaleUnit/src/main/royale/org/apache/royale/test/runners/MetadataRunner.as b/frameworks/projects/RoyaleUnit/src/main/royale/org/apache/royale/test/runners/MetadataRunner.as
index b96d664..08b8158 100644
--- a/frameworks/projects/RoyaleUnit/src/main/royale/org/apache/royale/test/runners/MetadataRunner.as
+++ b/frameworks/projects/RoyaleUnit/src/main/royale/org/apache/royale/test/runners/MetadataRunner.as
@@ -336,11 +336,19 @@ package org.apache.royale.test.runners
 			if(beforeClassDefinition != null)
 			{
 				_beforeClass = _testClass[beforeClassDefinition.name];
+				if(!_beforeClass)
+				{
+					_notifier.fireTestFailure(new Failure(description + ".initializationError", new Error("Reflection failed to locate static method <" + beforeClassDefinition.name + "> defined on type <" + beforeClassDefinition.declaredBy.qualifiedName + "> with [BeforeClass] metadata.")));
+				}
 			}
 			var afterClassDefinition:MethodDefinition = collectMethodWithMetadataTag(TestMetadata.AFTER_CLASS, true);
 			if(afterClassDefinition != null)
 			{
 				_afterClass = _testClass[afterClassDefinition.name];
+				if(!_afterClass)
+				{
+					_notifier.fireTestFailure(new Failure(description + ".initializationError", new Error("Reflection failed to locate static method <" + afterClassDefinition.name + "> defined on type <" + afterClassDefinition.declaredBy.qualifiedName + "> with [AfterClass] metadata.")));
+				}
 			}
 			var beforeDefinition:MethodDefinition = collectMethodWithMetadataTag(TestMetadata.BEFORE, true);
 			if(beforeDefinition != null)