[GitHub] cloud-fan commented on a change in pull request #23871: [SPARK-23433][SPARK-25250] [CORE] Later created TaskSet should learn about the finished partitions

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #23871: [SPARK-23433][SPARK-25250] [CORE] Later created TaskSet should learn about the finished partitions 
URL: https://github.com/apache/spark/pull/23871#discussion_r261470010
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
 ##########
 @@ -530,7 +530,7 @@ private[spark] class TaskSetManager(
 
   private def maybeFinishTaskSet() {
     if (isZombie && runningTasks == 0) {
-      sched.taskSetFinished(this)
+      sched.taskSetFinished(this, tasksSuccessful == numTasks)
 
 Review comment:
   Up to my knowledge, we can know a stage is finished in `DAGScheduler.markStageAsFinished`. Maybe we can clean up `stageIdToFinishedPartitions` there?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org