You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ignacio Vera (JIRA)" <ji...@apache.org> on 2018/03/25 13:16:00 UTC

[jira] [Comment Edited] (LUCENE-8220) GeoPolygon factory still shows problems with coplanar points

    [ https://issues.apache.org/jira/browse/LUCENE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413021#comment-16413021 ] 

Ignacio Vera edited comment on LUCENE-8220 at 3/25/18 1:15 PM:
---------------------------------------------------------------

I wanted to file a Jira ticket to add such a factory method, something like {{makeBestGeoPolygon}} and even offer the user to input the cut over if they want to do so.

This would be great as it could be used is the Geo3d wrapper!

I wonder if to avoid changing too much existing API, we might want to allow the current factory method {{makeGeoPolygon}} to fail in case of a tile exception and move the failover to the new factory method that does what you explain above. 


was (Author: ivera):
I wanted to file a Jira ticket to add such a factory method, something like {{makeBestGeoPolygon}} and even offer the user to input the cut over if they want to do so.

This would be great as it could be used is the Geo3d wrapper!

I wonder if to avoid changing too much existing API, we should allow the factory method {{makeGeoPolygon}} fail with a tile exception (nice, it can be recognized) and move the failover to a new factory method that does what you explain above. 

> GeoPolygon factory still shows problems with coplanar points
> ------------------------------------------------------------
>
>                 Key: LUCENE-8220
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8220
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Assignee: Karl Wright
>            Priority: Major
>         Attachments: concave.jpg, concaveWithTiling.jpg, coplanarity-test.patch, factory.patch
>
>
> The attached patch contains two polygons that still shows problems with co-planar points. To better explain the issue I attached some images:
> 1) concave.jpg:  This is the polygon we want to build. Note that we want to build the concave part, therefore the blue part is actually not part of the shape and the white part is the area cover by the shape.
> 2) concaveWithTiling.jpg: The algorithm of the polygon factory tries to tile the polygon using convex polygons. In our case it creates the three colored polygons on the image. What it remains is a concave polygon.
> The problem with this polygon is that the right edge of the concave polygon contains co-planar points. These points cannot be merged into a single plane because they have different properties (internal edges or shape edges).
> Because GeoConvexPolygon and GeoConcavePolygon cannot handle polygons with co-planar points, the polygon cannot be built.
> [~kwright@metacarta.com], Is it possible to make this polygons support such an extreme case?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org