You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/01/26 16:53:31 UTC
[GitHub] [solr] Caa52 opened a new pull request #566: Solr 12336 Remove Filter from Solr
Caa52 opened a new pull request #566:
URL: https://github.com/apache/solr/pull/566
https://issues.apache.org/jira/browse/SOLR-12336
# Description
Currently, we use the `getTopFilter` method in Filter to access a Query based on a DocSet. This is done via calling Filter's main method `getDocIdSet` and then calling an `iterator()`. However, with Filter going away, we still need the ability to have a Query based on a DocSet. Removing Filter requires reducing and possibly eliminating dependencies on `getDocIdSet` and implies that changes must be made to all callers that call Filter specific methods as well.
# Solution
To access a Query based on a DocSet without going through Filter:
- Create a new Query, `DocSetQuery`, that emulates the behavior of Filter
- Delete all calls to `getDocIdSet` which is Filter's main method
- Implement change to DocSet's API by replacing `getTopFilter` with `makeQuery` to help go from DocSet to a Query of the DocSet
- Delete Filter class
# Tests
Refactored all existing tests that were affected as a result of deleting Filter. Expanded test coverage by updating test suite to account for changes made. All tests are passing.
# Checklist
Please review the following and check all that apply:
- [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [X] I have created a Jira issue and added the issue ID to my pull request title.
- [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [X] I have developed this patch against the `main` branch.
- [X] I have run `./gradlew check`.
- [X] I have added tests for my changes.
- [X] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] Caa52 closed pull request #566: Solr 12336 Remove Filter from Solr
Posted by GitBox <gi...@apache.org>.
Caa52 closed pull request #566:
URL: https://github.com/apache/solr/pull/566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #566: Solr 12336 Remove Filter from Solr
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on a change in pull request #566:
URL: https://github.com/apache/solr/pull/566#discussion_r793014137
##########
File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.search;
+
+import org.apache.lucene.index.LeafReaderContext;
+import org.apache.lucene.search.ConstantScoreScorer;
+import org.apache.lucene.search.ConstantScoreWeight;
+import org.apache.lucene.search.DocIdSetIterator;
+import org.apache.lucene.search.IndexSearcher;
+import org.apache.lucene.search.Query;
+import org.apache.lucene.search.QueryVisitor;
+import org.apache.lucene.search.ScoreMode;
+import org.apache.lucene.search.Scorer;
+import org.apache.lucene.search.Weight;
+
+import java.io.IOException;
+import java.util.Objects;
+
+/**
+ * A class that accesses Queries based on a DocSet
+ *
+ * Refer SOLR-15257
+ */
+public class DocSetQuery extends Query implements DocSetProducer{
+ private final DocSet docSet;
+
+ public DocSetQuery(DocSet docSet) {
+ super();
+ this.docSet = docSet;
+ }
+
+ public DocSetQuery() {
+ docSet = null;
+ }
+
+ @Override
+ public String toString(String field) {
+ return "DocSetQuery(" + field + ")";
+ }
+
+ @Override
+ public void visit(QueryVisitor visitor) {
+ visitor.visitLeaf(this);
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ return sameClassAs(obj) && Objects.equals(docSet, getClass().cast(obj));
Review comment:
*EqualsIncompatibleType:* Calling equals on incompatible types DocSet and DocSetQuery [(details)](https://errorprone.info/bugpattern/EqualsIncompatibleType)
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] Caa52 edited a comment on pull request #566: Solr 12336 Remove Filter from Solr
Posted by GitBox <gi...@apache.org>.
Caa52 edited a comment on pull request #566:
URL: https://github.com/apache/solr/pull/566#issuecomment-1022446684
This is a new PR created as a continuation of the old one [SOLR-15257](https://github.com/apache/solr/pull/529). The old PR was closed as a result of renaming the branch to correctly reference the parent issue SOLR-12336. For context, please refer to the [old PR here](https://github.com/apache/solr/pull/529)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] Caa52 commented on pull request #566: Solr 12336 Remove Filter from Solr
Posted by GitBox <gi...@apache.org>.
Caa52 commented on pull request #566:
URL: https://github.com/apache/solr/pull/566#issuecomment-1022446684
This is a new PR created as a continuation of the old one [SOLR-15257](https://github.com/apache/solr/pull/529) The old PR was closed as a result of renaming the branch to correctly reference the parent issue SOLR-12336. For context, please refer to the [old PR here](https://github.com/apache/solr/pull/529)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org