[incubator-iceberg] branch master updated: Improve getWriter in BaseRewriteManifests (#790)

[ao...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

aokolnychyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-iceberg.git


The following commit(s) were added to refs/heads/master by this push:
     new 485b6b0  Improve getWriter in BaseRewriteManifests (#790)
485b6b0 is described below

commit 485b6b0fceb21c8510cfbe18e572adc1d66793ee
Author: jun-he <ju...@users.noreply.github.com>
AuthorDate: Fri Feb 14 10:38:21 2020 -0800

    Improve getWriter in BaseRewriteManifests (#790)
---
 .../main/java/org/apache/iceberg/BaseRewriteManifests.java   | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java b/core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java
index 39e7a7d..226df92 100644
--- a/core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java
+++ b/core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java
@@ -301,17 +301,7 @@ public class BaseRewriteManifests extends SnapshotProducer<RewriteManifests> imp
   }
 
   private WriterWrapper getWriter(Object key) {
-    WriterWrapper writer = writers.get(key);
-    if (writer == null) {
-      synchronized (writers) {
-        writer = writers.get(key); // check again after getting lock
-        if (writer == null) {
-          writer = new WriterWrapper();
-          writers.put(key, writer);
-        }
-      }
-    }
-    return writer;
+    return writers.computeIfAbsent(key, k -> new WriterWrapper());
   }
 
   @Override