You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/03/01 00:12:32 UTC

[kudu-CR] [tablet] don't call UpdateMetricsForOp() for rows with errors

Hello Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18281

to look at the new patch set (#2).

Change subject: [tablet] don't call UpdateMetricsForOp() for rows with errors
......................................................................

[tablet] don't call UpdateMetricsForOp() for rows with errors

This patch updates the control path in WriteOp::UpdatePerRowErrors()
to avoid calling UpdateMetricsForOp() for a row that contains an error
since that's effectively a no-op.

Also, renamed UpdatePerRowErrors() into UpdatePerRowMetricsAndErrors().

Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812
---
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/ops/write_op.h
2 files changed, 15 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/18281/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic1f57ee7d1b0064569a34ba93d35979426f76812
Gerrit-Change-Number: 18281
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)