You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Brian Relph (JIRA)" <ji...@apache.org> on 2008/08/12 16:42:25 UTC
[jira] Created: (WW-2760) Annotation-based Parameters Interceptor
Annotation-based Parameters Interceptor
---------------------------------------
Key: WW-2760
URL: https://issues.apache.org/struts/browse/WW-2760
Project: Struts 2
Issue Type: New Feature
Components: Core Interceptors
Affects Versions: 2.0.11.2
Reporter: Brian Relph
Assignee: Musachy Barroso
Priority: Minor
Annotation-based parameters interceptor. Extends ParametersInterceptor, and allows you to annotate both the class (for the default accept policy for parameters), and each property individually (that will override the class annotation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2760) Annotation-based Parameters Interceptor
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Musachy Barroso updated WW-2760:
--------------------------------
Fix Version/s: Future
Assignee: (was: Musachy Barroso)
> Annotation-based Parameters Interceptor
> ---------------------------------------
>
> Key: WW-2760
> URL: https://issues.apache.org/struts/browse/WW-2760
> Project: Struts 2
> Issue Type: New Feature
> Components: Core Interceptors
> Affects Versions: 2.0.11.2
> Reporter: Brian Relph
> Priority: Minor
> Fix For: Future
>
> Attachments: AcceptParameter.java, AcceptParameters.java, AnnotationParametersInterceptor.java, AnnotationParametersInterceptorTest.java
>
>
> Annotation-based parameters interceptor. Extends ParametersInterceptor, and allows you to annotate both the class (for the default accept policy for parameters), and each property individually (that will override the class annotation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2760) Annotation-based Parameters Interceptor
Posted by "Jelmer Kuperus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44554#action_44554 ]
Jelmer Kuperus commented on WW-2760:
------------------------------------
Specifying excludes is useful mostly when binding directly on domain objects, polluting those with web framework specific annotations seems like a bad idea to me. So that kind of limits the applicability of this solution
> Annotation-based Parameters Interceptor
> ---------------------------------------
>
> Key: WW-2760
> URL: https://issues.apache.org/struts/browse/WW-2760
> Project: Struts 2
> Issue Type: New Feature
> Components: Core Interceptors
> Affects Versions: 2.0.11.2
> Reporter: Brian Relph
> Assignee: Musachy Barroso
> Priority: Minor
> Attachments: AcceptParameter.java, AcceptParameters.java, AnnotationParametersInterceptor.java, AnnotationParametersInterceptorTest.java
>
>
> Annotation-based parameters interceptor. Extends ParametersInterceptor, and allows you to annotate both the class (for the default accept policy for parameters), and each property individually (that will override the class annotation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2760) Annotation-based Parameters Interceptor
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44558#action_44558 ]
Musachy Barroso commented on WW-2760:
-------------------------------------
I think it is good to have it as an option, but the implementation suffers from the same security vulnerability as WW-2761. It assumes that the field names will be plain names, and not OGNL expressions. This could be re-implemented adding the annotations check to com.opensymphony.xwork2.ognl.SecurityMemberAccess in xwork (trunk only), and would not require another interceptor.
> Annotation-based Parameters Interceptor
> ---------------------------------------
>
> Key: WW-2760
> URL: https://issues.apache.org/struts/browse/WW-2760
> Project: Struts 2
> Issue Type: New Feature
> Components: Core Interceptors
> Affects Versions: 2.0.11.2
> Reporter: Brian Relph
> Assignee: Musachy Barroso
> Priority: Minor
> Attachments: AcceptParameter.java, AcceptParameters.java, AnnotationParametersInterceptor.java, AnnotationParametersInterceptorTest.java
>
>
> Annotation-based parameters interceptor. Extends ParametersInterceptor, and allows you to annotate both the class (for the default accept policy for parameters), and each property individually (that will override the class annotation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2760) Annotation-based Parameters Interceptor
Posted by "Brian Relph (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Relph updated WW-2760:
----------------------------
Attachment: AnnotationParametersInterceptorTest.java
Test cases for annotation parameters interceptor
> Annotation-based Parameters Interceptor
> ---------------------------------------
>
> Key: WW-2760
> URL: https://issues.apache.org/struts/browse/WW-2760
> Project: Struts 2
> Issue Type: New Feature
> Components: Core Interceptors
> Affects Versions: 2.0.11.2
> Reporter: Brian Relph
> Assignee: Musachy Barroso
> Priority: Minor
> Attachments: AcceptParameter.java, AcceptParameters.java, AnnotationParametersInterceptor.java, AnnotationParametersInterceptorTest.java
>
>
> Annotation-based parameters interceptor. Extends ParametersInterceptor, and allows you to annotate both the class (for the default accept policy for parameters), and each property individually (that will override the class annotation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2760) Annotation-based Parameters Interceptor
Posted by "Brian Relph (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Relph updated WW-2760:
----------------------------
Attachment: AcceptParameter.java
AcceptParameters.java
AnnotationParametersInterceptor.java
Source for interceptor + annotations
> Annotation-based Parameters Interceptor
> ---------------------------------------
>
> Key: WW-2760
> URL: https://issues.apache.org/struts/browse/WW-2760
> Project: Struts 2
> Issue Type: New Feature
> Components: Core Interceptors
> Affects Versions: 2.0.11.2
> Reporter: Brian Relph
> Assignee: Musachy Barroso
> Priority: Minor
> Attachments: AcceptParameter.java, AcceptParameters.java, AnnotationParametersInterceptor.java
>
>
> Annotation-based parameters interceptor. Extends ParametersInterceptor, and allows you to annotate both the class (for the default accept policy for parameters), and each property individually (that will override the class annotation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.