You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "szehon-ho (via GitHub)" <gi...@apache.org> on 2025/10/30 18:19:58 UTC
[PR] [SPARK-53891][SQL][FOLLOW-UP] Clarify javadocs for case when merge summary metric is not found [spark]
szehon-ho opened a new pull request, #52797:
URL: https://github.com/apache/spark/pull/52797
### What changes were proposed in this pull request?
Clarify javadocs to explain situations where the metric is not found.
### Why are the changes needed?
As we begin to handle more write summaries like in https://github.com/apache/spark/pull/52669/, involving more complex walks of the executed plan graph, the code to calculate merge summary may encounter some plan it does not expect and would need to populate -1. Eventually we would handle all plans but there may be some gaps.
As it is not an expected case, we don't need to change the model of the MergeSummary to return Long or OptionalLong to advertise the possibility for null, so we can put -1 and indicate this in the javadoc.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53891][SQL][FOLLOW-UP] Clarify javadocs for case when merge summary metric is not found [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #52797:
URL: https://github.com/apache/spark/pull/52797#issuecomment-3471004252
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53891][SQL][FOLLOW-UP] Clarify javadocs for case when merge summary metric is not found [spark]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #52797:
URL: https://github.com/apache/spark/pull/52797#issuecomment-3470890206
test failure looks unrelated, re-running
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53891][SQL][FOLLOW-UP] Clarify javadocs for case when merge summary metric is not found [spark]
Posted by "szehon-ho (via GitHub)" <gi...@apache.org>.
szehon-ho commented on PR #52797:
URL: https://github.com/apache/spark/pull/52797#issuecomment-3474381885
thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53891][SQL][FOLLOW-UP] Clarify javadocs for case when merge summary metric is not found [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #52797: [SPARK-53891][SQL][FOLLOW-UP] Clarify javadocs for case when merge summary metric is not found
URL: https://github.com/apache/spark/pull/52797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org