[GitHub] [ozone] sokui commented on a diff in pull request #3835: HDDS-7329. Extend ozone admin datanode usageinfo and list info to accept hostname parameter

[GitBox <gi...@apache.org>]

sokui commented on code in PR #3835:
URL: https://github.com/apache/ozone/pull/3835#discussion_r1067839498


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java:
##########
@@ -373,6 +375,8 @@ public RegisteredCommand register(
 
     String dnsName;
     String networkLocation;
+    String ipAddress = datanodeDetails.getIpAddress();
+    String hostName = datanodeDetails.getHostName();

Review Comment:
   @kerneltime it has been so long time, I could not remember. But my testing environment is Kubernetes. I think when we deployed ozone, I see this happens a couple of times. But not sure what is the exact condition.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org