[jira] [Commented] (HADOOP-12327) Initialize output buffers with ZERO bytes in erasure coder

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699097#comment-14699097 ] 

Hadoop QA commented on HADOOP-12327:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  16m  4s | Findbugs (version ) appears to be broken on HDFS-7285. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 40s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 41s | There were no new javadoc warning messages. |
| {color:red}-1{color} | release audit |   0m 14s | The applied patch generated 1 release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m 15s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  1s | The patch has no lines that end in whitespace. |
| {color:green}+1{color} | install |   1m 40s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 35s | The patch built with eclipse:eclipse. |
| {color:red}-1{color} | findbugs |   5m 16s | The patch appears to introduce 5 new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | common tests |  21m 35s | Tests failed in hadoop-common. |
| {color:red}-1{color} | hdfs tests | 190m  8s | Tests failed in hadoop-hdfs. |
| | | 254m 16s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs |
| Failed unit tests | hadoop.net.TestNetUtils |
|   | hadoop.ha.TestZKFailoverController |
|   | hadoop.hdfs.TestWriteStripedFileWithFailure |
|   | hadoop.hdfs.server.namenode.TestFileTruncate |
|   | hadoop.hdfs.TestRollingUpgrade |
| Timed out tests | org.apache.hadoop.cli.TestHDFSCLI |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12750739/HADOOP-12327-HDFS-7285-v1.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | HDFS-7285 / b57c9a3 |
| Release Audit | https://builds.apache.org/job/PreCommit-HADOOP-Build/7489/artifact/patchprocess/patchReleaseAuditProblems.txt |
| Findbugs warnings | https://builds.apache.org/job/PreCommit-HADOOP-Build/7489/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html |
| hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7489/artifact/patchprocess/testrun_hadoop-common.txt |
| hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7489/artifact/patchprocess/testrun_hadoop-hdfs.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/7489/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/7489/console |


This message was automatically generated.

> Initialize output buffers with ZERO bytes in erasure coder
> ----------------------------------------------------------
>
>                 Key: HADOOP-12327
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12327
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>             Fix For: HDFS-7285
>
>         Attachments: HADOOP-12327-HDFS-7285-v1.patch
>
>
> Make sure output buffers are initialized with ZERO bytes in order for:
> * Coder callers won't have to bother doing that;
> * Avoid possible buggy codes if caller forgets doing that;
> * More efficiency, with a shared, length enough empty buffer allocated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)