You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by SHUANG SU <su...@gmail.com> on 2019/09/11 05:22:30 UTC
[VOTE] Release Apache ECharts (incubating) 4.3.0 (release candidate 2)
I am pleased to be calling this vote for the release of Apache ECharts
(incubating) 4.3.0 (release candidate 2).
Apache ECharts community has voted and approved the release.
Vote thread:
https://lists.apache.org/thread.html/67fd9865d480074d05e1343488ff8717f0e24a5a8e46617711e1652d@%3Cdev.echarts.apache.org%3E
Results thread:
https://lists.apache.org/thread.html/93647412b566a7f1d88c54b10d03f7b26e61d03278eb92afefa27334@%3Cdev.echarts.apache.org%3E
The release candidate to be voted over is available at:
https://dist.apache.org/repos/dist/dev/incubator/echarts/4.3.0-rc.2/
The release candidate is signed with a GPG key available at:
https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS
The Git commit for this release is:
https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=739033d
The Release Note is available in:
https://dist.apache.org/repos/dist/dev/incubator/echarts/4.3.0-rc.2/RELEASE_NOTE.txt
***
The changes from Apache ECharts (incubating) 4.3.0 (release candidate 1):
(1) Remove the author tags that are not removed. Author tag is brought by
previous
code style but has been not recommanded any more for long time.
(2) Remove the code snippet that has copyright issue from
`./src/component/toolbox/feature/DataView.js`.
(3) The previous code snippet that has copyright issue in
`./src/component/brush/selector.js` is
from a blog but seems like originally from a online lecture of an
university (where the link is not able to access).
We remove it and rewrite the code based on the fundamental math derivation.
(4) Remove all of the old website link `http://echarts.baidu.com` from the
comments of the code.
More details can be checked in:
https://github.com/apache/incubator-echarts/compare/b62ab99...739033d
***
Some shell commands for validating the release:
```shell
# Download the release:
curl
https://dist.apache.org/repos/dist/dev/incubator/echarts/4.3.0-rc.2/apache-echarts-4.3.0-rc.2-incubating-src.zip
-o apache-echarts-4.3.0-rc.2-incubating-src.zip
unzip apache-echarts-4.3.0-rc.2-incubating-src.zip -d
apache-echarts-4.3.0-rc.2-incubating-src > /dev/null
# Rebuild the project (Node.js environment is required):
cd "apache-echarts-4.3.0-rc.2-incubating-src" && npm install && cd ..
node "apache-echarts-4.3.0-rc.2-incubating-src/build/build.js" --release
# (See help: `node
"apache-echarts-4.3.0-rc.2-incubating-src/build/build.js" --help`)
```
Please vote on releasing this package as:
Apache ECharts (incubating) 4.3.0 (release candidate 2)
by "2019-09-14T06:19:36.893Z".
[ ] +1 Release this package
[ ] 0 I don't feel strongly about it, but don't object
[ ] -1 Do not release this package because...
Anyone can participate in testing and voting, not just committers, please
feel free to try out the release candidate and provide your votes.
A checklist for reference:
https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
Thanks,
------------------------------
Su Shuang (100pah)
------------------------------
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 2)
Posted by Sheng Wu <wu...@gmail.com>.
Hi
Thanks. I think that is the reason. I always use shasum Command for this.
Anyway, it is fine.
Sheng
SHUANG SU <su...@gmail.com>于2019年9月13日 周五上午3:35写道：
> Sheng,
>
> Currently, the sha512 is generated by `gpg` following the instruction [1],
> but not by `shasum`.
>
> The format of the generated sha512 files are different although the
> signatures are the same.
>
> If we generate the sha512 file using:
> ```shell
> shasum -a 512 apache-echarts-4.3.0-rc.2-incubating-src.zip
> ```
> We can verify it by:
> ```shell
> shasum -a 512 -c apache-echarts-4.3.0-rc.2-incubating-src.zip.sha512
> ```
> But if we use `gpg`, the verification command above seems do not work.
>
> (BTW, `shasum -c xxx` use `sha1` by default, so we should specify `-a
> 512`.)
>
>
> So for `gpg`, I have to verify it in this way:
> ```shell
> gpg --print-md SHA512 apache-echarts-4.3.0-rc.2-incubating-src.zip
> apache-echarts-4.3.0-rc.2-incubating-src.zip-local.sha512
> diff apache-echarts-4.3.0-rc.2-incubating-src.zip-local.sha512
> apache-echarts-4.3.0-rc.2-incubating-src.zip.sha512
> ```
> Is there a better way?
>
>
> [1] https://www.apache.org/dev/openpgp.html#generate-key
>
>
> ------------------------------
> Su Shuang (100pah)
> ------------------------------
>
>
>
> On Fri, 13 Sep 2019 at 05:45, Sheng Wu <wu...@gmail.com> wrote:
>
> > +1 binding
> >
> > Checked
> > - asc signed
> > - sha512 checked
> > - LICENSE and NOTICE there
> > - DISCLAIMER there
> >
> > One question, when I run
> > > shasum -c apache-echarts-4.3.0-rc.2-incubating-src.zip.sha512
> >
> > Got
> > > shasum: apache-echarts-4.3.0-rc.2-incubating-src.zip.sha512: no
> properly
> > formatted SHA1 checksum lines found
> >
> > I manually compared the sha512, they are matched. How do you generate the
> > sha512 file? And how do you check with command.
> >
> >
> > Sheng Wu 吴晟
> >
> > Apache SkyWalking
> > Apache Incubator
> > Apache ShardingSphere, ECharts, DolphinScheduler podlings
> > Zipkin
> > Twitter, wusheng1108
> >
> >
> > Dave Fisher <wa...@comcast.net> 于2019年9月12日周四 下午1:48写道：
> >
> > > +1 from me.
> > >
> > > I checked:
> > > - Incubating in name
> > > - DISCLAIMER exists
> > > - LICENSE and NOTICE are fine
> > > - No unexpected binary files
> > > - Checked signature and checksum
> > >
> > > We should discuss the build instructions compared to test build
> > > instructions on the dev@echarts mailing list.
> > >
> > > Regards,
> > > Dave
> > >
> > > > On Sep 12, 2019, at 6:42 AM, Dave Fisher <wa...@comcast.net>
> > wrote:
> > > >
> > > > Inline
> > > >
> > > > Sent from my iPhone
> > > >
> > > >> On Sep 12, 2019, at 3:18 AM, SHUANG SU <su...@gmail.com>
> > wrote:
> > > >>
> > > >> Justin & Furkan, thank you for the detailed check!
> > > >>
> > > >> There is a relevant build instruction in
> > > >>
> > >
> >
> https://echarts.apache.org/en/tutorial.html#Create%20Custom%20Build%20of%20ECharts
> > > >> and the link is listed in `README.md`.
> > > >>
> > > >> But I also think it is not clear enough and the doc is on the
> > > perspective
> > > >> of echarts user but not echarts contributor.
> > > >>
> > > >> I will add instruction of "how to build from the source code" to
> > > >> `README.md` directly,
> > > >> and add the entry of `npm run build` and `npm run build:watch` to
> > > >> `package.json`.
> > > >> Hope that makes it better.
> > > >>
> > > >> Because it is an enhancement, could we include this modification of
> > > >> `README.md`
> > > >> in the future release, but not in this release?
> > > >
> > > > Yes. Please make the change for the future while we continue this
> VOTE
> > > thread!
> > > >
> > > > Regards,
> > > > Dave
> > > >>
> > > >>
> > > >> Thanks,
> > > >> ------------------------------
> > > >> Su Shuang (100pah)
> > > >> ------------------------------
> > > >>
> > > >>
> > > >>
> > > >>> On Thu, 12 Sep 2019 at 17:25, Furkan KAMACI <
> furkankamaci@gmail.com>
> > > wrote:
> > > >>>
> > > >>> Hi,
> > > >>>
> > > >>> +1 from me.
> > > >>>
> > > >>> I checked:
> > > >>> - Incubating in name
> > > >>> - DISCLAIMER exists
> > > >>> - LICENSE and NOTICE are fine
> > > >>> - No unexpected binary files
> > > >>> - Checked PGP signatures
> > > >>> - Code compiles and tests successfully run
> > > >>>
> > > >>> I agree with Justin, build instructions should be more clear. On
> the
> > > other
> > > >>> hand, I'm not sure about the sha512 checksum file format.
> > > >>>
> > > >>> Kind Regards,
> > > >>> Furkan KAMACI
> > > >>>
> > > >>> On Thu, Sep 12, 2019 at 6:01 AM Justin Mclean <
> > > justin@classsoftware.com>
> > > >>> wrote:
> > > >>>
> > > >>>> Hi,
> > > >>>>
> > > >>>> +1 binding
> > > >>>>
> > > >>>> I checked:
> > > >>>> - incubating in a name
> > > >>>> - signature sand hashes correct
> > > >>>> - DISCLAIMER exists
> > > >>>> - LICENS and NOTICE file
> > > >>>> - Now unexpected binary files in the release
> > > >>>> - All source files have ASF headers
> > > >>>> - Compiled from source release
> > > >>>>
> > > >>>> It would be good to see some build instruction in the source
> > release.
> > > >>>> There’s a build directory but it unclear what need to be done to
> > build
> > > >>> it.
> > > >>>> I figured it out but it's not exactly obvious what is needed to be
> > > done.
> > > >>>>
> > > >>>> Thanks,
> > > >>>> Justin
> > > >>>>
> > > >>>>
> > > >>>>
> > ---------------------------------------------------------------------
> > > >>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > >>>> For additional commands, e-mail:
> general-help@incubator.apache.org
> > > >>>
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail: general-help@incubator.apache.org
> > > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: general-help@incubator.apache.org
> > >
> > >
> >
>
--
Sheng Wu
SkyWalking, Shardingsphere and Zipkin
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 2)
Posted by SHUANG SU <su...@gmail.com>.
Sheng,
Currently, the sha512 is generated by `gpg` following the instruction [1],
but not by `shasum`.
The format of the generated sha512 files are different although the
signatures are the same.
If we generate the sha512 file using:
```shell
shasum -a 512 apache-echarts-4.3.0-rc.2-incubating-src.zip
```
We can verify it by:
```shell
shasum -a 512 -c apache-echarts-4.3.0-rc.2-incubating-src.zip.sha512
```
But if we use `gpg`, the verification command above seems do not work.
(BTW, `shasum -c xxx` use `sha1` by default, so we should specify `-a 512`.)
So for `gpg`, I have to verify it in this way:
```shell
gpg --print-md SHA512 apache-echarts-4.3.0-rc.2-incubating-src.zip
apache-echarts-4.3.0-rc.2-incubating-src.zip-local.sha512
diff apache-echarts-4.3.0-rc.2-incubating-src.zip-local.sha512
apache-echarts-4.3.0-rc.2-incubating-src.zip.sha512
```
Is there a better way?
[1] https://www.apache.org/dev/openpgp.html#generate-key
------------------------------
Su Shuang (100pah)
------------------------------
On Fri, 13 Sep 2019 at 05:45, Sheng Wu <wu...@gmail.com> wrote:
> +1 binding
>
> Checked
> - asc signed
> - sha512 checked
> - LICENSE and NOTICE there
> - DISCLAIMER there
>
> One question, when I run
> > shasum -c apache-echarts-4.3.0-rc.2-incubating-src.zip.sha512
>
> Got
> > shasum: apache-echarts-4.3.0-rc.2-incubating-src.zip.sha512: no properly
> formatted SHA1 checksum lines found
>
> I manually compared the sha512, they are matched. How do you generate the
> sha512 file? And how do you check with command.
>
>
> Sheng Wu 吴晟
>
> Apache SkyWalking
> Apache Incubator
> Apache ShardingSphere, ECharts, DolphinScheduler podlings
> Zipkin
> Twitter, wusheng1108
>
>
> Dave Fisher <wa...@comcast.net> 于2019年9月12日周四 下午1:48写道：
>
> > +1 from me.
> >
> > I checked:
> > - Incubating in name
> > - DISCLAIMER exists
> > - LICENSE and NOTICE are fine
> > - No unexpected binary files
> > - Checked signature and checksum
> >
> > We should discuss the build instructions compared to test build
> > instructions on the dev@echarts mailing list.
> >
> > Regards,
> > Dave
> >
> > > On Sep 12, 2019, at 6:42 AM, Dave Fisher <wa...@comcast.net>
> wrote:
> > >
> > > Inline
> > >
> > > Sent from my iPhone
> > >
> > >> On Sep 12, 2019, at 3:18 AM, SHUANG SU <su...@gmail.com>
> wrote:
> > >>
> > >> Justin & Furkan, thank you for the detailed check!
> > >>
> > >> There is a relevant build instruction in
> > >>
> >
> https://echarts.apache.org/en/tutorial.html#Create%20Custom%20Build%20of%20ECharts
> > >> and the link is listed in `README.md`.
> > >>
> > >> But I also think it is not clear enough and the doc is on the
> > perspective
> > >> of echarts user but not echarts contributor.
> > >>
> > >> I will add instruction of "how to build from the source code" to
> > >> `README.md` directly,
> > >> and add the entry of `npm run build` and `npm run build:watch` to
> > >> `package.json`.
> > >> Hope that makes it better.
> > >>
> > >> Because it is an enhancement, could we include this modification of
> > >> `README.md`
> > >> in the future release, but not in this release?
> > >
> > > Yes. Please make the change for the future while we continue this VOTE
> > thread!
> > >
> > > Regards,
> > > Dave
> > >>
> > >>
> > >> Thanks,
> > >> ------------------------------
> > >> Su Shuang (100pah)
> > >> ------------------------------
> > >>
> > >>
> > >>
> > >>> On Thu, 12 Sep 2019 at 17:25, Furkan KAMACI <fu...@gmail.com>
> > wrote:
> > >>>
> > >>> Hi,
> > >>>
> > >>> +1 from me.
> > >>>
> > >>> I checked:
> > >>> - Incubating in name
> > >>> - DISCLAIMER exists
> > >>> - LICENSE and NOTICE are fine
> > >>> - No unexpected binary files
> > >>> - Checked PGP signatures
> > >>> - Code compiles and tests successfully run
> > >>>
> > >>> I agree with Justin, build instructions should be more clear. On the
> > other
> > >>> hand, I'm not sure about the sha512 checksum file format.
> > >>>
> > >>> Kind Regards,
> > >>> Furkan KAMACI
> > >>>
> > >>> On Thu, Sep 12, 2019 at 6:01 AM Justin Mclean <
> > justin@classsoftware.com>
> > >>> wrote:
> > >>>
> > >>>> Hi,
> > >>>>
> > >>>> +1 binding
> > >>>>
> > >>>> I checked:
> > >>>> - incubating in a name
> > >>>> - signature sand hashes correct
> > >>>> - DISCLAIMER exists
> > >>>> - LICENS and NOTICE file
> > >>>> - Now unexpected binary files in the release
> > >>>> - All source files have ASF headers
> > >>>> - Compiled from source release
> > >>>>
> > >>>> It would be good to see some build instruction in the source
> release.
> > >>>> There’s a build directory but it unclear what need to be done to
> build
> > >>> it.
> > >>>> I figured it out but it's not exactly obvious what is needed to be
> > done.
> > >>>>
> > >>>> Thanks,
> > >>>> Justin
> > >>>>
> > >>>>
> > >>>>
> ---------------------------------------------------------------------
> > >>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > >>>> For additional commands, e-mail: general-help@incubator.apache.org
> > >>>
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: general-help@incubator.apache.org
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 2)
Posted by Sheng Wu <wu...@gmail.com>.
+1 binding
Checked
- asc signed
- sha512 checked
- LICENSE and NOTICE there
- DISCLAIMER there
One question, when I run
> shasum -c apache-echarts-4.3.0-rc.2-incubating-src.zip.sha512
Got
> shasum: apache-echarts-4.3.0-rc.2-incubating-src.zip.sha512: no properly
formatted SHA1 checksum lines found
I manually compared the sha512, they are matched. How do you generate the
sha512 file? And how do you check with command.
Sheng Wu 吴晟
Apache SkyWalking
Apache Incubator
Apache ShardingSphere, ECharts, DolphinScheduler podlings
Zipkin
Twitter, wusheng1108
Dave Fisher <wa...@comcast.net> 于2019年9月12日周四 下午1:48写道：
> +1 from me.
>
> I checked:
> - Incubating in name
> - DISCLAIMER exists
> - LICENSE and NOTICE are fine
> - No unexpected binary files
> - Checked signature and checksum
>
> We should discuss the build instructions compared to test build
> instructions on the dev@echarts mailing list.
>
> Regards,
> Dave
>
> > On Sep 12, 2019, at 6:42 AM, Dave Fisher <wa...@comcast.net> wrote:
> >
> > Inline
> >
> > Sent from my iPhone
> >
> >> On Sep 12, 2019, at 3:18 AM, SHUANG SU <su...@gmail.com> wrote:
> >>
> >> Justin & Furkan, thank you for the detailed check!
> >>
> >> There is a relevant build instruction in
> >>
> https://echarts.apache.org/en/tutorial.html#Create%20Custom%20Build%20of%20ECharts
> >> and the link is listed in `README.md`.
> >>
> >> But I also think it is not clear enough and the doc is on the
> perspective
> >> of echarts user but not echarts contributor.
> >>
> >> I will add instruction of "how to build from the source code" to
> >> `README.md` directly,
> >> and add the entry of `npm run build` and `npm run build:watch` to
> >> `package.json`.
> >> Hope that makes it better.
> >>
> >> Because it is an enhancement, could we include this modification of
> >> `README.md`
> >> in the future release, but not in this release?
> >
> > Yes. Please make the change for the future while we continue this VOTE
> thread!
> >
> > Regards,
> > Dave
> >>
> >>
> >> Thanks,
> >> ------------------------------
> >> Su Shuang (100pah)
> >> ------------------------------
> >>
> >>
> >>
> >>> On Thu, 12 Sep 2019 at 17:25, Furkan KAMACI <fu...@gmail.com>
> wrote:
> >>>
> >>> Hi,
> >>>
> >>> +1 from me.
> >>>
> >>> I checked:
> >>> - Incubating in name
> >>> - DISCLAIMER exists
> >>> - LICENSE and NOTICE are fine
> >>> - No unexpected binary files
> >>> - Checked PGP signatures
> >>> - Code compiles and tests successfully run
> >>>
> >>> I agree with Justin, build instructions should be more clear. On the
> other
> >>> hand, I'm not sure about the sha512 checksum file format.
> >>>
> >>> Kind Regards,
> >>> Furkan KAMACI
> >>>
> >>> On Thu, Sep 12, 2019 at 6:01 AM Justin Mclean <
> justin@classsoftware.com>
> >>> wrote:
> >>>
> >>>> Hi,
> >>>>
> >>>> +1 binding
> >>>>
> >>>> I checked:
> >>>> - incubating in a name
> >>>> - signature sand hashes correct
> >>>> - DISCLAIMER exists
> >>>> - LICENS and NOTICE file
> >>>> - Now unexpected binary files in the release
> >>>> - All source files have ASF headers
> >>>> - Compiled from source release
> >>>>
> >>>> It would be good to see some build instruction in the source release.
> >>>> There’s a build directory but it unclear what need to be done to build
> >>> it.
> >>>> I figured it out but it's not exactly obvious what is needed to be
> done.
> >>>>
> >>>> Thanks,
> >>>> Justin
> >>>>
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >>>> For additional commands, e-mail: general-help@incubator.apache.org
> >>>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 2)
Posted by Dave Fisher <wa...@comcast.net>.
+1 from me.
I checked:
- Incubating in name
- DISCLAIMER exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked signature and checksum
We should discuss the build instructions compared to test build instructions on the dev@echarts mailing list.
Regards,
Dave
> On Sep 12, 2019, at 6:42 AM, Dave Fisher <wa...@comcast.net> wrote:
>
> Inline
>
> Sent from my iPhone
>
>> On Sep 12, 2019, at 3:18 AM, SHUANG SU <su...@gmail.com> wrote:
>>
>> Justin & Furkan, thank you for the detailed check!
>>
>> There is a relevant build instruction in
>> https://echarts.apache.org/en/tutorial.html#Create%20Custom%20Build%20of%20ECharts
>> and the link is listed in `README.md`.
>>
>> But I also think it is not clear enough and the doc is on the perspective
>> of echarts user but not echarts contributor.
>>
>> I will add instruction of "how to build from the source code" to
>> `README.md` directly,
>> and add the entry of `npm run build` and `npm run build:watch` to
>> `package.json`.
>> Hope that makes it better.
>>
>> Because it is an enhancement, could we include this modification of
>> `README.md`
>> in the future release, but not in this release?
>
> Yes. Please make the change for the future while we continue this VOTE thread!
>
> Regards,
> Dave
>>
>>
>> Thanks,
>> ------------------------------
>> Su Shuang (100pah)
>> ------------------------------
>>
>>
>>
>>> On Thu, 12 Sep 2019 at 17:25, Furkan KAMACI <fu...@gmail.com> wrote:
>>>
>>> Hi,
>>>
>>> +1 from me.
>>>
>>> I checked:
>>> - Incubating in name
>>> - DISCLAIMER exists
>>> - LICENSE and NOTICE are fine
>>> - No unexpected binary files
>>> - Checked PGP signatures
>>> - Code compiles and tests successfully run
>>>
>>> I agree with Justin, build instructions should be more clear. On the other
>>> hand, I'm not sure about the sha512 checksum file format.
>>>
>>> Kind Regards,
>>> Furkan KAMACI
>>>
>>> On Thu, Sep 12, 2019 at 6:01 AM Justin Mclean <ju...@classsoftware.com>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> +1 binding
>>>>
>>>> I checked:
>>>> - incubating in a name
>>>> - signature sand hashes correct
>>>> - DISCLAIMER exists
>>>> - LICENS and NOTICE file
>>>> - Now unexpected binary files in the release
>>>> - All source files have ASF headers
>>>> - Compiled from source release
>>>>
>>>> It would be good to see some build instruction in the source release.
>>>> There’s a build directory but it unclear what need to be done to build
>>> it.
>>>> I figured it out but it's not exactly obvious what is needed to be done.
>>>>
>>>> Thanks,
>>>> Justin
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release candidate 2)
Posted by Dave Fisher <wa...@comcast.net>.
Inline
Sent from my iPhone
> On Sep 12, 2019, at 3:18 AM, SHUANG SU <su...@gmail.com> wrote:
>
> Justin & Furkan, thank you for the detailed check!
>
> There is a relevant build instruction in
> https://echarts.apache.org/en/tutorial.html#Create%20Custom%20Build%20of%20ECharts
> and the link is listed in `README.md`.
>
> But I also think it is not clear enough and the doc is on the perspective
> of echarts user but not echarts contributor.
>
> I will add instruction of "how to build from the source code" to
> `README.md` directly,
> and add the entry of `npm run build` and `npm run build:watch` to
> `package.json`.
> Hope that makes it better.
>
> Because it is an enhancement, could we include this modification of
> `README.md`
> in the future release, but not in this release?
Yes. Please make the change for the future while we continue this VOTE thread!
Regards,
Dave
>
>
> Thanks,
> ------------------------------
> Su Shuang (100pah)
> ------------------------------
>
>
>
>> On Thu, 12 Sep 2019 at 17:25, Furkan KAMACI <fu...@gmail.com> wrote:
>>
>> Hi,
>>
>> +1 from me.
>>
>> I checked:
>> - Incubating in name
>> - DISCLAIMER exists
>> - LICENSE and NOTICE are fine
>> - No unexpected binary files
>> - Checked PGP signatures
>> - Code compiles and tests successfully run
>>
>> I agree with Justin, build instructions should be more clear. On the other
>> hand, I'm not sure about the sha512 checksum file format.
>>
>> Kind Regards,
>> Furkan KAMACI
>>
>> On Thu, Sep 12, 2019 at 6:01 AM Justin Mclean <ju...@classsoftware.com>
>> wrote:
>>
>>> Hi,
>>>
>>> +1 binding
>>>
>>> I checked:
>>> - incubating in a name
>>> - signature sand hashes correct
>>> - DISCLAIMER exists
>>> - LICENS and NOTICE file
>>> - Now unexpected binary files in the release
>>> - All source files have ASF headers
>>> - Compiled from source release
>>>
>>> It would be good to see some build instruction in the source release.
>>> There’s a build directory but it unclear what need to be done to build
>> it.
>>> I figured it out but it's not exactly obvious what is needed to be done.
>>>
>>> Thanks,
>>> Justin
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: general-help@incubator.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 2)
Posted by SHUANG SU <su...@gmail.com>.
Justin & Furkan, thank you for the detailed check!
There is a relevant build instruction in
https://echarts.apache.org/en/tutorial.html#Create%20Custom%20Build%20of%20ECharts
and the link is listed in `README.md`.
But I also think it is not clear enough and the doc is on the perspective
of echarts user but not echarts contributor.
I will add instruction of "how to build from the source code" to
`README.md` directly,
and add the entry of `npm run build` and `npm run build:watch` to
`package.json`.
Hope that makes it better.
Because it is an enhancement, could we include this modification of
`README.md`
in the future release, but not in this release?
Thanks,
------------------------------
Su Shuang (100pah)
------------------------------
On Thu, 12 Sep 2019 at 17:25, Furkan KAMACI <fu...@gmail.com> wrote:
> Hi,
>
> +1 from me.
>
> I checked:
> - Incubating in name
> - DISCLAIMER exists
> - LICENSE and NOTICE are fine
> - No unexpected binary files
> - Checked PGP signatures
> - Code compiles and tests successfully run
>
> I agree with Justin, build instructions should be more clear. On the other
> hand, I'm not sure about the sha512 checksum file format.
>
> Kind Regards,
> Furkan KAMACI
>
> On Thu, Sep 12, 2019 at 6:01 AM Justin Mclean <ju...@classsoftware.com>
> wrote:
>
> > Hi,
> >
> > +1 binding
> >
> > I checked:
> > - incubating in a name
> > - signature sand hashes correct
> > - DISCLAIMER exists
> > - LICENS and NOTICE file
> > - Now unexpected binary files in the release
> > - All source files have ASF headers
> > - Compiled from source release
> >
> > It would be good to see some build instruction in the source release.
> > There’s a build directory but it unclear what need to be done to build
> it.
> > I figured it out but it's not exactly obvious what is needed to be done.
> >
> > Thanks,
> > Justin
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 2)
Posted by Furkan KAMACI <fu...@gmail.com>.
Hi,
+1 from me.
I checked:
- Incubating in name
- DISCLAIMER exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked PGP signatures
- Code compiles and tests successfully run
I agree with Justin, build instructions should be more clear. On the other
hand, I'm not sure about the sha512 checksum file format.
Kind Regards,
Furkan KAMACI
On Thu, Sep 12, 2019 at 6:01 AM Justin Mclean <ju...@classsoftware.com>
wrote:
> Hi,
>
> +1 binding
>
> I checked:
> - incubating in a name
> - signature sand hashes correct
> - DISCLAIMER exists
> - LICENS and NOTICE file
> - Now unexpected binary files in the release
> - All source files have ASF headers
> - Compiled from source release
>
> It would be good to see some build instruction in the source release.
> There’s a build directory but it unclear what need to be done to build it.
> I figured it out but it's not exactly obvious what is needed to be done.
>
> Thanks,
> Justin
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache ECharts (incubating) 4.3.0 (release
candidate 2)
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
+1 binding
I checked:
- incubating in a name
- signature sand hashes correct
- DISCLAIMER exists
- LICENS and NOTICE file
- Now unexpected binary files in the release
- All source files have ASF headers
- Compiled from source release
It would be good to see some build instruction in the source release. There’s a build directory but it unclear what need to be done to build it. I figured it out but it's not exactly obvious what is needed to be done.
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org