You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/10/07 15:37:00 UTC
[jira] [Work logged] (GOBBLIN-1279) Fix flaky unit tests involving
REST.li calls to FlowConfig endpoint in Gobblin-as-a-Service
[ https://issues.apache.org/jira/browse/GOBBLIN-1279?focusedWorklogId=496690&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-496690 ]
ASF GitHub Bot logged work on GOBBLIN-1279:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Oct/20 15:36
Start Date: 07/Oct/20 15:36
Worklog Time Spent: 10m
Work Description: sv2000 opened a new pull request #3119:
URL: https://github.com/apache/incubator-gobblin/pull/3119
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1279
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Full local build of Apache Gobblin intermittently fails due to unit tests involving FlowConfig endpoint experiencing REST.li timeout exception. The current default timeout of 1s appears insufficient. This task enhances the FlowConfig class to pass a set of overrideable properties for configuring the REST.li client, including the HTTP request timeout value. The unit tests creating the FlowConfig client are appropriately modified to provide a higher timeout value.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Modified existing unit tests. Also, ran ./gradlew clean build 3 successive times to verify build is successful.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 496690)
Remaining Estimate: 0h
Time Spent: 10m
> Fix flaky unit tests involving REST.li calls to FlowConfig endpoint in Gobblin-as-a-Service
> -------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1279
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1279
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Full local build of Apache Gobblin intermittently fails due to unit tests involving FlowConfig endpoint experiencing REST.li timeout exception. The current default timeout of 1s appears insufficient. This task enhances the FlowConfig class to pass a set of overrideable properties for configuring the REST.li client, including the HTTP request timeout value. The unit tests creating the FlowConfig client are appropriately modified to provide a higher timeout value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)