You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/10 12:13:08 UTC
[GitHub] [inlong] pocozh opened a new pull request, #5467: [INLONG-5164][Agent] BinlogReader adds audit and metrics
pocozh opened a new pull request, #5467:
URL: https://github.com/apache/inlong/pull/5467
### Prepare a Pull Request
*(Change the title refer to the following example)*
- [INLONG-5164][Agent] BinlogReader adds audit and metrics
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes #5164
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] pocozh commented on a diff in pull request #5467: [INLONG-5164][Agent] BinlogReader adds audit and metrics
Posted by GitBox <gi...@apache.org>.
pocozh commented on code in PR #5467:
URL: https://github.com/apache/inlong/pull/5467#discussion_r943064189
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/metrics/audit/AuditUtils.java:
##########
@@ -69,6 +69,12 @@ public static void initAudit() {
}
}
+ public static void add(int auditID, String inlongGroupId, String inlongStreamId, long logTime, int count) {
Review Comment:
> Please, add doc
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on a diff in pull request #5467: [INLONG-5164][Agent] BinlogReader adds audit and metrics
Posted by GitBox <gi...@apache.org>.
GanfengTan commented on code in PR #5467:
URL: https://github.com/apache/inlong/pull/5467#discussion_r942379492
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/metrics/audit/AuditUtils.java:
##########
@@ -69,6 +69,12 @@ public static void initAudit() {
}
}
+ public static void add(int auditID, String inlongGroupId, String inlongStreamId, long logTime, int count) {
Review Comment:
Please, add doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5467: [INLONG-5164][Agent] BinlogReader adds audit and metrics
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5467:
URL: https://github.com/apache/inlong/pull/5467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org