You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/03/21 19:06:00 UTC
[jira] [Work logged] (KNOX-2307) CSVKnoxShellTableBuilder must
support quoted strings and embedded commas
[ https://issues.apache.org/jira/browse/KNOX-2307?focusedWorklogId=407500&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407500 ]
ASF GitHub Bot logged work on KNOX-2307:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/20 19:05
Start Date: 21/Mar/20 19:05
Worklog Time Spent: 10m
Work Description: lmccay commented on pull request #298: KNOX-2307
URL: https://github.com/apache/knox/pull/298
(It is very **important** that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!)
## What changes were proposed in this pull request?
Support for quoted strings with embedded commans within CSV files to be parsed into KnoxShellTable instance.
## How was this patch tested?
Unit test added and existing unit tests ran.
Manual testing with datasets that include such embedded commas and quoted string values.
Please review [Knox Contributing Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow) before opening a pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 407500)
Remaining Estimate: 0h
Time Spent: 10m
> CSVKnoxShellTableBuilder must support quoted strings and embedded commas
> ------------------------------------------------------------------------
>
> Key: KNOX-2307
> URL: https://issues.apache.org/jira/browse/KNOX-2307
> Project: Apache Knox
> Issue Type: Improvement
> Components: KnoxShell
> Reporter: Larry McCay
> Assignee: Larry McCay
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Embedded commas within a quoted string/col in CSV files result in separate cols currently. This patch allows for them to be ignored during the split() call via regex for identifying such patterns.
> It will result in the value - either header or cell value - as retaining the quotes currently. If this is not desired we can revisit and make configurable or just removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)