You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2024/09/07 08:38:12 UTC
[PR] [improve][pip] PIP-377: Automatic retry for failed acknowledgements [pulsar]
lhotari opened a new pull request, #23267:
URL: https://github.com/apache/pulsar/pull/23267
### Motivation
In the pip-377.md file
### Modifications
In the pip-377.md file
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [x] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][pip] PIP-377: Automatic retry for failed acknowledgements [pulsar]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on PR #23267:
URL: https://github.com/apache/pulsar/pull/23267#issuecomment-2345491849
Is there a precise step to reproduce the acknowledgment lost?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][pip] PIP-377: Automatic retry for failed acknowledgements [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #23267:
URL: https://github.com/apache/pulsar/pull/23267#issuecomment-2345777428
> Is there a precise step to reproduce the acknowledgment lost?
@aloyszhang not yet, there's #22709 and #21958 where it seems that acks get lost.
One possible way that it could happen is due to #23200 where the number of ack holes exceeds the default limit of 10000 and the consumer gets reconnected at this time (client connection breaks or due to load balancing event).
There was a previous attempt to limit the number of ack holes with PIP-299. The problem is that it won't prevent exceeding the limit. The problem described in #23200 is addressed with #23231 (which I'm currently working on).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][pip] PIP-377: Automatic retry for failed acknowledgements [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #23267:
URL: https://github.com/apache/pulsar/pull/23267#issuecomment-4596071371
#25525 makes this obsolete and addresses the actual issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][pip] PIP-377: Automatic retry for failed acknowledgements [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari closed pull request #23267: [improve][pip] PIP-377: Automatic retry for failed acknowledgements
URL: https://github.com/apache/pulsar/pull/23267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org