[GitHub] [spark] tgravescs commented on a diff in pull request #37268: [SPARK-39853][CORE] Support stage level task resource profile for standalone cluster when dynamic allocation disabled

[GitBox <gi...@apache.org>]

tgravescs commented on code in PR #37268:
URL: https://github.com/apache/spark/pull/37268#discussion_r940350925


##########
core/src/main/scala/org/apache/spark/resource/ResourceProfile.scala:
##########
@@ -76,6 +76,11 @@ class ResourceProfile(
     executorResources.asJava
   }
 
+  /**
+   * Target executor's resource profile id, used for schedule.
+   */
+  def targetExecutorRpId: Int = id

Review Comment:
   while that sounds like an interesting workaround, the id if public, so if I create a task resource profile that has the same id as another one, that seems odd right?  Also I think that would break the UI, or at least make it funny without other changes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org