You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2018/07/28 13:10:55 UTC

svn commit: r1836901 - /pdfbox/branches/2.0/examples/src/test/java/org/apache/wink/client/MockHttpServer.java

Author: tilman
Date: Sat Jul 28 13:10:55 2018
New Revision: 1836901

URL: http://svn.apache.org/viewvc?rev=1836901&view=rev
Log:
PDFBOX-4281: small code cleanup

Modified:
    pdfbox/branches/2.0/examples/src/test/java/org/apache/wink/client/MockHttpServer.java

Modified: pdfbox/branches/2.0/examples/src/test/java/org/apache/wink/client/MockHttpServer.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/examples/src/test/java/org/apache/wink/client/MockHttpServer.java?rev=1836901&r1=1836900&r2=1836901&view=diff
==============================================================================
--- pdfbox/branches/2.0/examples/src/test/java/org/apache/wink/client/MockHttpServer.java (original)
+++ pdfbox/branches/2.0/examples/src/test/java/org/apache/wink/client/MockHttpServer.java Sat Jul 28 13:10:55 2018
@@ -31,6 +31,7 @@ import java.net.ServerSocket;
 import java.net.Socket;
 import java.net.SocketException;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -51,7 +52,7 @@ public class MockHttpServer extends Thre
 
         // mock response data
         private int                 mockResponseCode        = 200;
-        private Map<String, String> mockResponseHeaders     = new HashMap<String, String>();
+        private final Map<String, String> mockResponseHeaders = new HashMap<String, String>();
         private byte[]              mockResponseContent     = "received message".getBytes();
         private String              mockResponseContentType = "text/plain;charset=utf-8";
         private boolean             mockResponseContentEchoRequest;
@@ -179,6 +180,7 @@ public class MockHttpServer extends Thre
         }
     }
 
+    @Override
     public void run() {
         serverThread = Thread.currentThread();
         executeLoop();
@@ -341,7 +343,7 @@ public class MockHttpServer extends Thre
 
         private void processChunkedContent(InputStream is) throws IOException {
             requestContent.write("".getBytes());
-            byte[] chunk = null;
+            byte[] chunk;
             byte[] line = null;
             boolean lastChunk = false;
             // we should exit this loop only after we get to the end of stream
@@ -529,9 +531,7 @@ public class MockHttpServer extends Thre
 
     public void setMockHttpServerResponses(MockHttpServerResponse... responses) {
         mockHttpServerResponses.clear();
-        for (int i = 0; i < responses.length; i++) {
-            mockHttpServerResponses.add(responses[i]);
-        }
+        mockHttpServerResponses.addAll(Arrays.asList(responses));
     }
 
     public List<MockHttpServerResponse> getMockHttpServerResponses() {