You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/22 06:59:38 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #34679: [SPARK-37437][BUILD] remove unused hive profile
AngersZhuuuu opened a new pull request #34679:
URL: https://github.com/apache/spark/pull/34679
### What changes were proposed in this pull request?
Since we only support hive-2.3, we should remove the unused profile.
### Why are the changes needed?
remove unused profile
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Not need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile and related CI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-977574783
**[Test build #145561 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145561/testReport)** for PR 34679 at commit [`a8bdab5`](https://github.com/apache/spark/commit/a8bdab59977244ef5541c301ef4ee175acb84e83).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34679: [SPARK-37437][BUILD] remove unused hive profile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-975185148
**[Test build #145500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145500/testReport)** for PR 34679 at commit [`f78af65`](https://github.com/apache/spark/commit/f78af6584fa1f899dbab6e3abd2db07dcb22d022).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #34679:
URL: https://github.com/apache/spark/pull/34679#discussion_r755675181
##########
File path: pom.xml
##########
@@ -3353,11 +3353,6 @@
<!-- Default hadoop profile. Uses global properties. -->
</profile>
- <profile>
Review comment:
After you remove this? Won't maven say that the profile doesn't exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile and related CI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-977497183
**[Test build #145561 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145561/testReport)** for PR 34679 at commit [`a8bdab5`](https://github.com/apache/spark/commit/a8bdab59977244ef5541c301ef4ee175acb84e83).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile and related CI test
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34679:
URL: https://github.com/apache/spark/pull/34679#discussion_r756564108
##########
File path: pom.xml
##########
@@ -3353,11 +3353,6 @@
<!-- Default hadoop profile. Uses global properties. -->
</profile>
- <profile>
Review comment:
Can you mention this in the PR description? Saying that -Phive-2.3 still works after removing the profile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-975185148
**[Test build #145500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145500/testReport)** for PR 34679 at commit [`f78af65`](https://github.com/apache/spark/commit/f78af6584fa1f899dbab6e3abd2db07dcb22d022).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile and related CI test
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-977497183
**[Test build #145561 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145561/testReport)** for PR 34679 at commit [`a8bdab5`](https://github.com/apache/spark/commit/a8bdab59977244ef5541c301ef4ee175acb84e83).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile and related CI test
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-981318255
+1, late LGTM. Thank you all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-975347010
gentle ping @dongjoon-hyun @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-975341595
**[Test build #145500 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145500/testReport)** for PR 34679 at commit [`f78af65`](https://github.com/apache/spark/commit/f78af6584fa1f899dbab6e3abd2db07dcb22d022).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #34679:
URL: https://github.com/apache/spark/pull/34679#discussion_r755673065
##########
File path: pom.xml
##########
@@ -3353,11 +3353,6 @@
<!-- Default hadoop profile. Uses global properties. -->
</profile>
- <profile>
Review comment:
No, I just mean do not remove the profile, so that specifying it does not fail the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile and related CI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-977557629
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50033/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile and related CI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-977557629
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50033/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-975217339
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49973/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile and related CI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-977585617
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145561/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile and related CI test
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-977585617
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145561/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #34679:
URL: https://github.com/apache/spark/pull/34679#discussion_r755672634
##########
File path: pom.xml
##########
@@ -3353,11 +3353,6 @@
<!-- Default hadoop profile. Uses global properties. -->
</profile>
- <profile>
Review comment:
> We could possibly leave the profile in and have it still do nothing, as if the profile doesn't exist, a build with -Phive-2.3 fails, even though it's really "OK" - it's already hive 2.3 by default. I don't feel strongly about it.
you mean `test-hive2.3`? I think this won't work now and we don't need this too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #34679:
URL: https://github.com/apache/spark/pull/34679#discussion_r755675902
##########
File path: pom.xml
##########
@@ -3353,11 +3353,6 @@
<!-- Default hadoop profile. Uses global properties. -->
</profile>
- <profile>
Review comment:
yea, won't failed with a profile doesn't exist, So I make this pr. I know your concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-975287935
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49973/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-975343643
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145500/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile and related CI test
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-980497001
ping @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile and related CI test
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #34679:
URL: https://github.com/apache/spark/pull/34679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile and related CI test
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #34679:
URL: https://github.com/apache/spark/pull/34679#discussion_r756564572
##########
File path: pom.xml
##########
@@ -3353,11 +3353,6 @@
<!-- Default hadoop profile. Uses global properties. -->
</profile>
- <profile>
Review comment:
>
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile and related CI test
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-980638790
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile and related CI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-977533473
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50033/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile and related CI test
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-977551358
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50033/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile and related CI test
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-978821760
@srowen do you have more concerns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-975343643
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145500/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile and related CI test
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-978816344
Also ping @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #34679:
URL: https://github.com/apache/spark/pull/34679#discussion_r755238638
##########
File path: pom.xml
##########
@@ -3353,11 +3353,6 @@
<!-- Default hadoop profile. Uses global properties. -->
</profile>
- <profile>
Review comment:
We could possibly leave the profile in and have it still do nothing, as if the profile doesn't exist, a build with -Phive-2.3 fails, even though it's really "OK" - it's already hive 2.3 by default. I don't feel strongly about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #34679:
URL: https://github.com/apache/spark/pull/34679#discussion_r755674382
##########
File path: pom.xml
##########
@@ -3353,11 +3353,6 @@
<!-- Default hadoop profile. Uses global properties. -->
</profile>
- <profile>
Review comment:
> No, I just mean do not remove the profile, so that specifying it does not fail the build
But build with a `-Phive-2.3` won't failed too...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-975277786
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49973/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34679: [SPARK-37437][BUILD] Remove unused hive profile
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34679:
URL: https://github.com/apache/spark/pull/34679#issuecomment-975287935
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49973/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org