You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "tzulitai (via GitHub)" <gi...@apache.org> on 2023/06/01 20:18:35 UTC
[GitHub] [flink-connector-kafka] tzulitai opened a new pull request, #31: [FLINK-31747] Remove Confluent Avro formats from externalized Kafka connector repo
tzulitai opened a new pull request, #31:
URL: https://github.com/apache/flink-connector-kafka/pull/31
This PR removes again the Confluent Avro related formats from the externalized Kafka connector repo.
This was a result of a discussion with @twalthr. The formats will remain in the core `apache/flink` repo, as they can be commonly used by various different connectors and not just the Kafka connector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] tzulitai closed pull request #31: [FLINK-31747] Remove Confluent Avro formats from externalized Kafka connector repo
Posted by "tzulitai (via GitHub)" <gi...@apache.org>.
tzulitai closed pull request #31: [FLINK-31747] Remove Confluent Avro formats from externalized Kafka connector repo
URL: https://github.com/apache/flink-connector-kafka/pull/31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] tzulitai commented on pull request #31: [FLINK-31747] Remove Confluent Avro formats from externalized Kafka connector repo
Posted by "tzulitai (via GitHub)" <gi...@apache.org>.
tzulitai commented on PR #31:
URL: https://github.com/apache/flink-connector-kafka/pull/31#issuecomment-1578888866
Good point @mas-chen. Following along the same logic for how other tests in `apache/flink` that depend on the Kafka connector handle this (i.e. pinning to a specific Kafka connector version), I guess we would do the same here for [flink-confluent-schema-registry-e2e-tests](https://issues.apache.org/jira/browse/FLINK-confluent-schema-registry-e2e-tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] mas-chen commented on pull request #31: [FLINK-31747] Remove Confluent Avro formats from externalized Kafka connector repo
Posted by "mas-chen (via GitHub)" <gi...@apache.org>.
mas-chen commented on PR #31:
URL: https://github.com/apache/flink-connector-kafka/pull/31#issuecomment-1581530114
Looks good aside from the CI error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] tzulitai commented on pull request #31: [FLINK-31747] Remove Confluent Avro formats from externalized Kafka connector repo
Posted by "tzulitai (via GitHub)" <gi...@apache.org>.
tzulitai commented on PR #31:
URL: https://github.com/apache/flink-connector-kafka/pull/31#issuecomment-1594806537
Seems to be a flaky test. I'll re-run to be sure and open a ticket for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] tzulitai commented on pull request #31: [FLINK-31747] Remove Confluent Avro formats from externalized Kafka connector repo
Posted by "tzulitai (via GitHub)" <gi...@apache.org>.
tzulitai commented on PR #31:
URL: https://github.com/apache/flink-connector-kafka/pull/31#issuecomment-1572721547
cc @mas-chen @twalthr for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org