You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kgyrtkirk (via GitHub)" <gi...@apache.org> on 2023/09/18 14:18:17 UTC
[PR] Enable SortProjectTransposeRule (druid)
kgyrtkirk opened a new pull request, #15002:
URL: https://github.com/apache/druid/pull/15002
* contains #14996
* enables a transpose rule to support a query plan in which the plan was in the shape:
{code}
Sort
Project
Aggregate
{code}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Enable SortProjectTransposeRule (druid)
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 merged PR #15002:
URL: https://github.com/apache/druid/pull/15002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Enable SortProjectTransposeRule (druid)
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 commented on code in PR #15002:
URL: https://github.com/apache/druid/pull/15002#discussion_r1336997190
##########
extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/quantiles/sql/DoublesSketchSqlAggregatorTest.java:
##########
@@ -692,13 +692,13 @@ public void testDoublesSketchPostAggsPostSort()
0.5
),
new DoublesSketchToQuantilePostAggregator(
- "s1",
- new FieldAccessPostAggregator("s0", "a0:agg"),
+ "_p1",
+ new FieldAccessPostAggregator("_p0", "a0:agg"),
Review Comment:
Why did these change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Enable SortProjectTransposeRule (druid)
Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk commented on code in PR #15002:
URL: https://github.com/apache/druid/pull/15002#discussion_r1338429124
##########
extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/quantiles/sql/DoublesSketchSqlAggregatorTest.java:
##########
@@ -692,13 +692,13 @@ public void testDoublesSketchPostAggsPostSort()
0.5
),
new DoublesSketchToQuantilePostAggregator(
- "s1",
- new FieldAccessPostAggregator("s0", "a0:agg"),
+ "_p1",
+ new FieldAccessPostAggregator("_p0", "a0:agg"),
Review Comment:
there are 2 callsites to create the postaggregates - one of them uses `p` and the other `s` as prefix; I was getting almost 100% matching plans with column alias mistmatches because of the different prefixes - so I've changed that; as the main importance of them is to have them unique.
I've today tried to remove the change of that prefix thing - and I think that change might not be needed in this patch.
I've update the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org