You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/01/10 01:45:02 UTC
[GitHub] [incubator-gobblin] codecov-io commented on issue #2863: GOBBLIN-1016: Allow Gobblin Application Master to join Helix cluster …
codecov-io commented on issue #2863: GOBBLIN-1016: Allow Gobblin Application Master to join Helix cluster …
URL: https://github.com/apache/incubator-gobblin/pull/2863#issuecomment-572836083
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr&el=h1) Report
> Merging [#2863](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4483268e3885adb63da7253df5ab0c00eb86aece?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `57.14%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2863 +/- ##
============================================
+ Coverage 45.72% 45.76% +0.04%
- Complexity 9085 9107 +22
============================================
Files 1913 1917 +4
Lines 72021 72147 +126
Branches 7943 7963 +20
============================================
+ Hits 32929 33019 +90
- Misses 36074 36102 +28
- Partials 3018 3026 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ache/gobblin/cluster/GobblinHelixMultiManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4TXVsdGlNYW5hZ2VyLmphdmE=) | `54.16% <ø> (ø)` | `19 <0> (ø)` | :arrow_down: |
| [.../gobblin/cluster/GobblinHelixMessagingService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4TWVzc2FnaW5nU2VydmljZS5qYXZh) | `63.04% <0%> (-2.13%)` | `4 <0> (ø)` | |
| [...e/gobblin/yarn/AbstractYarnAppSecurityManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vQWJzdHJhY3RZYXJuQXBwU2VjdXJpdHlNYW5hZ2VyLmphdmE=) | `48.75% <100%> (+2.59%)` | `6 <1> (+3)` | :arrow_up: |
| [...obblin/yarn/YarnAppSecurityManagerWithKeytabs.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFybkFwcFNlY3VyaXR5TWFuYWdlcldpdGhLZXl0YWJzLmphdmE=) | `25.64% <33.33%> (+5.05%)` | `2 <0> (ø)` | :arrow_down: |
| [...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh) | `21.39% <90.9%> (+1.44%)` | `8 <0> (+1)` | :arrow_up: |
| [...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh) | `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
| [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `92.85% <0%> (-7.15%)` | `3% <0%> (-1%)` | |
| [...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==) | `30.2% <0%> (-0.68%)` | `24% <0%> (-1%)` | |
| [...pache/gobblin/runtime/GobblinMultiTaskAttempt.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvR29iYmxpbk11bHRpVGFza0F0dGVtcHQuamF2YQ==) | `55.85% <0%> (-0.46%)` | `26% <0%> (-1%)` | |
| [...n/compaction/action/CompactionWatermarkAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25XYXRlcm1hcmtBY3Rpb24uamF2YQ==) | `77.04% <0%> (ø)` | `11% <0%> (?)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2863/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr&el=footer). Last update [4483268...5f46ba5](https://codecov.io/gh/apache/incubator-gobblin/pull/2863?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services