You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/07 17:06:34 UTC

[GitHub] [flink] RocMarshal opened a new pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

RocMarshal opened a new pull request #13088:
URL: https://github.com/apache/flink/pull/13088


   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   *Translate the 'Side Outputs' page of 'DataStream API' into Chinese*
   
   
   ## Brief change log
   
   *Translate the 'Side Outputs' page of 'DataStream API' into Chinese*
     - *The page url is https://ci.apache.org/projects/flink/flink-docs-release-1.11/zh/dev/stream/side_output.html*
     - *The markdown file is located in flink/docs/dev/stream/side_output.zh.md*
   
   
   ## Verifying this change
   * A pure documentation translation 
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? no
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] RocMarshal commented on a change in pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #13088:
URL: https://github.com/apache/flink/pull/13088#discussion_r469304928



##########
File path: docs/dev/stream/side_output.zh.md
##########
@@ -26,21 +26,15 @@ under the License.
 * This will be replaced by the TOC
 {:toc}
 
-In addition to the main stream that results from `DataStream` operations, you can also produce any
-number of additional side output result streams. The type of data in the result streams does not
-have to match the type of data in the main stream and the types of the different side outputs can
-also differ. This operation can be useful when you want to split a stream of data where you would
-normally have to replicate the stream and then filter out from each stream the data that you don't
-want to have.
+除了由 `DataStream` 操作产生的主要流之外,你还可以产生任意数量的旁路输出结果流。结果流中的数据类型不必与主要流中的数据类型相匹配,并且不同旁路输出的类型也可以不同。当你想要拆分数据流时,此操作非常有用,通常你必须复制数据流,然后从每个数据流中过滤掉你不想保留的数据。

Review comment:
       ```suggestion
   除了由 `DataStream` 操作产生的主要流之外,你还可以产生任意数量的旁路输出结果流。结果流中的数据类型不必与主要流中的数据类型相匹配,并且不同旁路输出的类型也可以不同。当你需要拆分数据流时,通常必须复制该数据流,然后从每个流中过滤掉不需要的数据,这个操作十分有用。
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13088:
URL: https://github.com/apache/flink/pull/13088#issuecomment-670624360


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c9e436eff90e8ba0b2dfc8578d4173227bf6cb6d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5297",
       "triggerID" : "c9e436eff90e8ba0b2dfc8578d4173227bf6cb6d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e976b9e55145c4f52efd750ecb56067986a8b34c",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5330",
       "triggerID" : "e976b9e55145c4f52efd750ecb56067986a8b34c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80507ac0202292dd9477762342cf6a440db1f1b7",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5464",
       "triggerID" : "80507ac0202292dd9477762342cf6a440db1f1b7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 80507ac0202292dd9477762342cf6a440db1f1b7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5464) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] XBaith commented on a change in pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
XBaith commented on a change in pull request #13088:
URL: https://github.com/apache/flink/pull/13088#discussion_r467664455



##########
File path: docs/dev/stream/side_output.zh.md
##########
@@ -110,17 +101,15 @@ val mainDataStream = input
       // emit data to regular output

Review comment:
       发送数据到主要的输出

##########
File path: docs/dev/stream/side_output.zh.md
##########
@@ -26,21 +26,15 @@ under the License.
 * This will be replaced by the TOC
 {:toc}
 
-In addition to the main stream that results from `DataStream` operations, you can also produce any
-number of additional side output result streams. The type of data in the result streams does not
-have to match the type of data in the main stream and the types of the different side outputs can
-also differ. This operation can be useful when you want to split a stream of data where you would
-normally have to replicate the stream and then filter out from each stream the data that you don't
-want to have.
+除了由 `DataStream` 操作产生的主要流之外,你还可以产生任意数量的旁路输出结果流。结果流中的数据类型不必与主要流中的数据类型相匹配,并且不同旁路输出的类型也可以不同。当你想要拆分数据流时,此操作非常有用,通常你必须复制数据流,然后从每个数据流中过滤掉你不想保留的数据。
 
-When using side outputs, you first need to define an `OutputTag` that will be used to identify a
-side output stream:
+使用旁路输出时,首先需要定义用于标识旁路输出流的 `OutputTag`:
 
 <div class="codetabs" markdown="1">
 <div data-lang="java" markdown="1">
 
 {% highlight java %}
-// this needs to be an anonymous inner class, so that we can analyze the type
+// 这需要是一个匿名的内部类,这样我们才能分析类型

Review comment:
       ```suggestion
   // 这需要是一个匿名的内部类,以便我们分析类型
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13088:
URL: https://github.com/apache/flink/pull/13088#issuecomment-670624360


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c9e436eff90e8ba0b2dfc8578d4173227bf6cb6d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5297",
       "triggerID" : "c9e436eff90e8ba0b2dfc8578d4173227bf6cb6d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e976b9e55145c4f52efd750ecb56067986a8b34c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5330",
       "triggerID" : "e976b9e55145c4f52efd750ecb56067986a8b34c",
       "triggerType" : "PUSH"
     }, {
       "hash" : "80507ac0202292dd9477762342cf6a440db1f1b7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "80507ac0202292dd9477762342cf6a440db1f1b7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e976b9e55145c4f52efd750ecb56067986a8b34c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5330) 
   * 80507ac0202292dd9477762342cf6a440db1f1b7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13088:
URL: https://github.com/apache/flink/pull/13088#issuecomment-670618141


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c9e436eff90e8ba0b2dfc8578d4173227bf6cb6d (Fri Aug 07 17:09:15 UTC 2020)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] RocMarshal commented on pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #13088:
URL: https://github.com/apache/flink/pull/13088#issuecomment-670787752


   Hi, @XBaith  .
   Could you help me to review this PR if you have free time?
   Thank you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong merged pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #13088:
URL: https://github.com/apache/flink/pull/13088


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] RocMarshal commented on pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #13088:
URL: https://github.com/apache/flink/pull/13088#issuecomment-671153087


   @XBaith 
   Thank you for your review.
   I made some changes according to you suggestions. That looks better now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] RocMarshal commented on a change in pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #13088:
URL: https://github.com/apache/flink/pull/13088#discussion_r469307221



##########
File path: docs/dev/stream/side_output.zh.md
##########
@@ -26,21 +26,15 @@ under the License.
 * This will be replaced by the TOC
 {:toc}
 
-In addition to the main stream that results from `DataStream` operations, you can also produce any
-number of additional side output result streams. The type of data in the result streams does not
-have to match the type of data in the main stream and the types of the different side outputs can
-also differ. This operation can be useful when you want to split a stream of data where you would
-normally have to replicate the stream and then filter out from each stream the data that you don't
-want to have.
+除了由 `DataStream` 操作产生的主要流之外,你还可以产生任意数量的旁路输出结果流。结果流中的数据类型不必与主要流中的数据类型相匹配,并且不同旁路输出的类型也可以不同。当你想要拆分数据流时,此操作非常有用,通常你必须复制数据流,然后从每个数据流中过滤掉你不想保留的数据。

Review comment:
       > `当你想要拆分数据流时,此操作非常有用,通常你必须复制数据流,然后从每个数据流中过滤掉你不想保留的数据。` 这句话能否调整下顺序呢?读起来感觉有点像英文的说法方式
   
   @klion26 
   Thank you so much for your suggestions.
   
   Done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] RocMarshal commented on pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #13088:
URL: https://github.com/apache/flink/pull/13088#issuecomment-671338165


   LGTM.
   @klion26 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] RocMarshal edited a comment on pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
RocMarshal edited a comment on pull request #13088:
URL: https://github.com/apache/flink/pull/13088#issuecomment-675246790


   LGTM
   ping @wuchong @rmetzger  @zentol 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13088:
URL: https://github.com/apache/flink/pull/13088#issuecomment-670624360


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c9e436eff90e8ba0b2dfc8578d4173227bf6cb6d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c9e436eff90e8ba0b2dfc8578d4173227bf6cb6d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c9e436eff90e8ba0b2dfc8578d4173227bf6cb6d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13088:
URL: https://github.com/apache/flink/pull/13088#issuecomment-670624360


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c9e436eff90e8ba0b2dfc8578d4173227bf6cb6d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5297",
       "triggerID" : "c9e436eff90e8ba0b2dfc8578d4173227bf6cb6d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e976b9e55145c4f52efd750ecb56067986a8b34c",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5330",
       "triggerID" : "e976b9e55145c4f52efd750ecb56067986a8b34c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e976b9e55145c4f52efd750ecb56067986a8b34c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5330) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13088:
URL: https://github.com/apache/flink/pull/13088#issuecomment-670624360


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c9e436eff90e8ba0b2dfc8578d4173227bf6cb6d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5297",
       "triggerID" : "c9e436eff90e8ba0b2dfc8578d4173227bf6cb6d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c9e436eff90e8ba0b2dfc8578d4173227bf6cb6d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5297) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] RocMarshal commented on pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #13088:
URL: https://github.com/apache/flink/pull/13088#issuecomment-675246790


   LGTM
   ping @wuchong @rmetzger


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13088:
URL: https://github.com/apache/flink/pull/13088#issuecomment-670624360


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c9e436eff90e8ba0b2dfc8578d4173227bf6cb6d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5297",
       "triggerID" : "c9e436eff90e8ba0b2dfc8578d4173227bf6cb6d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e976b9e55145c4f52efd750ecb56067986a8b34c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e976b9e55145c4f52efd750ecb56067986a8b34c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c9e436eff90e8ba0b2dfc8578d4173227bf6cb6d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5297) 
   * e976b9e55145c4f52efd750ecb56067986a8b34c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] RocMarshal commented on a change in pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #13088:
URL: https://github.com/apache/flink/pull/13088#discussion_r469307221



##########
File path: docs/dev/stream/side_output.zh.md
##########
@@ -26,21 +26,15 @@ under the License.
 * This will be replaced by the TOC
 {:toc}
 
-In addition to the main stream that results from `DataStream` operations, you can also produce any
-number of additional side output result streams. The type of data in the result streams does not
-have to match the type of data in the main stream and the types of the different side outputs can
-also differ. This operation can be useful when you want to split a stream of data where you would
-normally have to replicate the stream and then filter out from each stream the data that you don't
-want to have.
+除了由 `DataStream` 操作产生的主要流之外,你还可以产生任意数量的旁路输出结果流。结果流中的数据类型不必与主要流中的数据类型相匹配,并且不同旁路输出的类型也可以不同。当你想要拆分数据流时,此操作非常有用,通常你必须复制数据流,然后从每个数据流中过滤掉你不想保留的数据。

Review comment:
       @klion26 
   Thank you so much for your suggestions.
   
   Done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] klion26 commented on a change in pull request #13088: [FLINK-18814][docs-zh] Translate the 'Side Outputs' page of 'DataStream API' into Chinese

Posted by GitBox <gi...@apache.org>.
klion26 commented on a change in pull request #13088:
URL: https://github.com/apache/flink/pull/13088#discussion_r469014440



##########
File path: docs/dev/stream/side_output.zh.md
##########
@@ -26,21 +26,15 @@ under the License.
 * This will be replaced by the TOC
 {:toc}
 
-In addition to the main stream that results from `DataStream` operations, you can also produce any
-number of additional side output result streams. The type of data in the result streams does not
-have to match the type of data in the main stream and the types of the different side outputs can
-also differ. This operation can be useful when you want to split a stream of data where you would
-normally have to replicate the stream and then filter out from each stream the data that you don't
-want to have.
+除了由 `DataStream` 操作产生的主要流之外,你还可以产生任意数量的旁路输出结果流。结果流中的数据类型不必与主要流中的数据类型相匹配,并且不同旁路输出的类型也可以不同。当你想要拆分数据流时,此操作非常有用,通常你必须复制数据流,然后从每个数据流中过滤掉你不想保留的数据。

Review comment:
       `当你想要拆分数据流时,此操作非常有用,通常你必须复制数据流,然后从每个数据流中过滤掉你不想保留的数据。` 这句话能否调整下顺序呢?读起来感觉有点像英文的说法方式




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org