You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/05/30 19:02:02 UTC
[kudu-CR] [client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7017
Change subject: [client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus
......................................................................
[client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus
Stop injecting a latency on tserver shutdown in the
ClientTest.TestLastErrorEmbeddedInScanTimeoutStatus test, so the tablet
servers are shutting down faster, making the overall test runtime
shorter (~4 vs ~16 seconds). Besides, it makes it less likely that
some other process binds to the port where the tserver's webserver is
about to re-bind upon restart.
Change-Id: If959b53616a3c0cc1193d57d181f4b0ff034cc83
---
M src/kudu/client/client-test.cc
1 file changed, 26 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/7017/1
--
To view, visit http://gerrit.cloudera.org:8080/7017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If959b53616a3c0cc1193d57d181f4b0ff034cc83
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If959b53616a3c0cc1193d57d181f4b0ff034cc83
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7017/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
PS1, Line 4779: // Revert the latency injection flags on the shutdown of tablet servers
: // and at the end so the test exits faster.
:
I think the old comment still makes sense here. We're only _reverting_ the change at the end of the test. It's just that we didn't _make_ the change until after the Shutdown call.
--
To view, visit http://gerrit.cloudera.org:8080/7017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If959b53616a3c0cc1193d57d181f4b0ff034cc83
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus
......................................................................
[client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus
Stop injecting a latency on tserver shutdown in the
ClientTest.TestLastErrorEmbeddedInScanTimeoutStatus test, so the tablet
servers are shutting down faster, making the overall test runtime
shorter (~4 vs ~16 seconds). Besides, it makes it less likely that
some other process binds to the port where the tserver's webserver is
about to re-bind upon restart.
Change-Id: If959b53616a3c0cc1193d57d181f4b0ff034cc83
Reviewed-on: http://gerrit.cloudera.org:8080/7017
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/client/client-test.cc
1 file changed, 25 insertions(+), 23 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If959b53616a3c0cc1193d57d181f4b0ff034cc83
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7017/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
PS1, Line 4779: // Revert the latency injection flags on the shutdown of tablet servers
: // and at the end so the test exits faster.
:
> I think the old comment still makes sense here. We're only _reverting_ the
Indeed -- it's a good catch. :)
--
To view, visit http://gerrit.cloudera.org:8080/7017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If959b53616a3c0cc1193d57d181f4b0ff034cc83
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7017
to look at the new patch set (#2).
Change subject: [client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus
......................................................................
[client-test] fix for TestLastErrorEmbeddedInScanTimeoutStatus
Stop injecting a latency on tserver shutdown in the
ClientTest.TestLastErrorEmbeddedInScanTimeoutStatus test, so the tablet
servers are shutting down faster, making the overall test runtime
shorter (~4 vs ~16 seconds). Besides, it makes it less likely that
some other process binds to the port where the tserver's webserver is
about to re-bind upon restart.
Change-Id: If959b53616a3c0cc1193d57d181f4b0ff034cc83
---
M src/kudu/client/client-test.cc
1 file changed, 25 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/7017/2
--
To view, visit http://gerrit.cloudera.org:8080/7017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If959b53616a3c0cc1193d57d181f4b0ff034cc83
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>