You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@manifoldcf.apache.org by Alessandro Benedetti <be...@gmail.com> on 2014/10/07 13:24:56 UTC
[Solr Output Connector] Empty field check
Hi guys,
just taking a look into Solr Connector code we did months ago ( the part
related to not using the Extract update handler ) ...
I believe can be useful to avoid the indexing of empty fields.
It's only a small refinement, but maybe can be good to avoid anomalies.
What do you think ?
Cheers
--
--------------------------
Benedetti Alessandro
Visiting card : http://about.me/alessandro_benedetti
"Tyger, tyger burning bright
In the forests of the night,
What immortal hand or eye
Could frame thy fearful symmetry?"
William Blake - Songs of Experience -1794 England
Re: [Solr Output Connector] Empty field check
Posted by Karl Wright <da...@gmail.com>.
Hi Alessandro,
The tests are still there in the branches/CONNECTORS-856 branch, and we
haven't had a chance to work on repurposing them. If you would like maybe
you can submit a new solr connector unit test patch against trunk, which
doesn't use power-mock.
Karl
On Tue, Oct 7, 2014 at 7:35 AM, Alessandro Benedetti <
benedetti.alex85@gmail.com> wrote:
> That's cool !
> Honestly the tests I did months ago were really too much coupled to the
> implementation, so I would design them better right now.
>
> But at least I tried to test the private methods.
> Good to know that now we have the mock support :)
>
>
> 2014-10-07 12:33 GMT+01:00 Karl Wright <da...@gmail.com>:
>
> > CONNECTORS-1066.
> >
> > By the way, we now have a working mock framework in place. But, only
> > mockito and wire-mock; no power-mock.
> >
> >
> > Karl
> >
>
>
>
> --
> --------------------------
>
> Benedetti Alessandro
> Visiting card : http://about.me/alessandro_benedetti
>
> "Tyger, tyger burning bright
> In the forests of the night,
> What immortal hand or eye
> Could frame thy fearful symmetry?"
>
> William Blake - Songs of Experience -1794 England
>
Re: [Solr Output Connector] Empty field check
Posted by Alessandro Benedetti <be...@gmail.com>.
That's cool !
Honestly the tests I did months ago were really too much coupled to the
implementation, so I would design them better right now.
But at least I tried to test the private methods.
Good to know that now we have the mock support :)
2014-10-07 12:33 GMT+01:00 Karl Wright <da...@gmail.com>:
> CONNECTORS-1066.
>
> By the way, we now have a working mock framework in place. But, only
> mockito and wire-mock; no power-mock.
>
>
> Karl
>
--
--------------------------
Benedetti Alessandro
Visiting card : http://about.me/alessandro_benedetti
"Tyger, tyger burning bright
In the forests of the night,
What immortal hand or eye
Could frame thy fearful symmetry?"
William Blake - Songs of Experience -1794 England
Re: [Solr Output Connector] Empty field check
Posted by Karl Wright <da...@gmail.com>.
CONNECTORS-1066.
By the way, we now have a working mock framework in place. But, only
mockito and wire-mock; no power-mock.
Karl
Re: [Solr Output Connector] Empty field check
Posted by Alessandro Benedetti <be...@gmail.com>.
Will you create an issue Karl ?
And then I can simply generate the super small patch ?
Cheers
2014-10-07 12:26 GMT+01:00 Karl Wright <da...@gmail.com>:
> It sounds fine to me.
> Karl
>
> On Tue, Oct 7, 2014 at 7:24 AM, Alessandro Benedetti <
> benedetti.alex85@gmail.com> wrote:
>
> > Hi guys,
> > just taking a look into Solr Connector code we did months ago ( the part
> > related to not using the Extract update handler ) ...
> >
> > I believe can be useful to avoid the indexing of empty fields.
> > It's only a small refinement, but maybe can be good to avoid anomalies.
> >
> > What do you think ?
> >
> > Cheers
> >
> > --
> > --------------------------
> >
> > Benedetti Alessandro
> > Visiting card : http://about.me/alessandro_benedetti
> >
> > "Tyger, tyger burning bright
> > In the forests of the night,
> > What immortal hand or eye
> > Could frame thy fearful symmetry?"
> >
> > William Blake - Songs of Experience -1794 England
> >
>
--
--------------------------
Benedetti Alessandro
Visiting card : http://about.me/alessandro_benedetti
"Tyger, tyger burning bright
In the forests of the night,
What immortal hand or eye
Could frame thy fearful symmetry?"
William Blake - Songs of Experience -1794 England
Re: [Solr Output Connector] Empty field check
Posted by Karl Wright <da...@gmail.com>.
It sounds fine to me.
Karl
On Tue, Oct 7, 2014 at 7:24 AM, Alessandro Benedetti <
benedetti.alex85@gmail.com> wrote:
> Hi guys,
> just taking a look into Solr Connector code we did months ago ( the part
> related to not using the Extract update handler ) ...
>
> I believe can be useful to avoid the indexing of empty fields.
> It's only a small refinement, but maybe can be good to avoid anomalies.
>
> What do you think ?
>
> Cheers
>
> --
> --------------------------
>
> Benedetti Alessandro
> Visiting card : http://about.me/alessandro_benedetti
>
> "Tyger, tyger burning bright
> In the forests of the night,
> What immortal hand or eye
> Could frame thy fearful symmetry?"
>
> William Blake - Songs of Experience -1794 England
>