You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "chitralverma (via GitHub)" <gi...@apache.org> on 2025/12/08 07:53:56 UTC
[PR] fix formatting using taplo [opendal]
chitralverma opened a new pull request, #6877:
URL: https://github.com/apache/opendal/pull/6877
# Which issue does this PR close?
ref: https://github.com/apache/opendal/issues/6829
# Rationale for this change
fix formatting for tomls using the existing taplo configs
```bash
# Run in the root of the project
taplo fmt --config .taplo.toml
```
# What changes are included in this PR?
- formatting fix
# Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix formatting using taplo [opendal]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #6877:
URL: https://github.com/apache/opendal/pull/6877#discussion_r2597698510
##########
core/Cargo.toml:
##########
@@ -26,7 +26,6 @@ members = [
"benches/vs_*",
"services/*",
"layers/*",
- "layers/await-tree",
]
Review Comment:
The workspace member `"layers/await-tree"` is being removed from the members list, but this directory still exists and is referenced elsewhere in the file (line 165: `opendal-layer-await-tree = { path = "layers/await-tree", version = "0.55.0", optional = true, default-features = false }`).
If this is a formatting change by taplo, it suggests this entry might be redundant since `"layers/*"` on line 28 already includes all layers. However, removing it could be unintentional if it was explicitly listed for a reason. Please verify this is the intended behavior of your taplo configuration.
##########
bindings/nodejs/Cargo.toml:
##########
@@ -82,7 +82,6 @@ services-all = [
"services-mongodb",
"services-gridfs",
"services-sqlite",
- "services-alluxio",
"services-b2",
Review Comment:
The feature `"services-alluxio"` is being removed from the `services-all` feature list on line 85, but it still appears to have its own feature definition later in the file. Additionally, `"services-compfs"` is being moved from line 148 to line 114 (in alphabetical order).
If taplo is removing `services-alluxio` from `services-all`, this could be unintentional behavior unless the service is deliberately being excluded. Please verify that:
1. Removing `services-alluxio` from `services-all` is intended
2. This is expected behavior from your taplo configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix formatting using taplo [opendal]
Posted by "chitralverma (via GitHub)" <gi...@apache.org>.
chitralverma commented on code in PR #6877:
URL: https://github.com/apache/opendal/pull/6877#discussion_r2598288091
##########
core/core/Cargo.toml:
##########
@@ -320,7 +320,6 @@ web-sys = { version = "0.3.77", optional = true, features = [
"FileSystemWritableFileStream",
"Navigator",
"StorageManager",
- "FileSystemGetFileOptions",
Review Comment:
this was a duplicate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix formatting using taplo [opendal]
Posted by "chitralverma (via GitHub)" <gi...@apache.org>.
chitralverma commented on code in PR #6877:
URL: https://github.com/apache/opendal/pull/6877#discussion_r2597432469
##########
bindings/nodejs/Cargo.toml:
##########
@@ -82,7 +82,6 @@ services-all = [
"services-mongodb",
"services-gridfs",
"services-sqlite",
- "services-alluxio",
Review Comment:
this was duplicate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix formatting using taplo [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6877:
URL: https://github.com/apache/opendal/pull/6877#issuecomment-3625792101
> Shall i include these changes as well in this PR ?
Yep, I think that's a good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: fix formatting using taplo [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #6877:
URL: https://github.com/apache/opendal/pull/6877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix formatting using taplo [opendal]
Posted by "chitralverma (via GitHub)" <gi...@apache.org>.
chitralverma commented on code in PR #6877:
URL: https://github.com/apache/opendal/pull/6877#discussion_r2597433519
##########
core/Cargo.toml:
##########
@@ -26,7 +26,6 @@ members = [
"benches/vs_*",
"services/*",
"layers/*",
- "layers/await-tree",
Review Comment:
already covered by `layers/*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix formatting using taplo [opendal]
Posted by "chitralverma (via GitHub)" <gi...@apache.org>.
chitralverma commented on PR #6877:
URL: https://github.com/apache/opendal/pull/6877#issuecomment-3625510442
@Xuanwo i started this PR as a simple formatting task but I see that as part of the crate splitting task, there is a lot of duplicate stuff in the tomls.
I suggest the following,
- Common package metadata should be inherited from the `core` workspace
```
[package]
name = "..." # crate specific
description = "..." # crate specific
keywords = [] # crate specific or may not ??
readme = "README.md" # crate specific
authors = { workspace = true } # since these are all common to opendal
edition = { workspace = true }
homepage = { workspace = true }
license = { workspace = true }
repository = { workspace = true }
rust-version = { workspace = true }
version = { workspace = true } # since these are release together anyways
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix formatting using taplo [opendal]
Posted by "chitralverma (via GitHub)" <gi...@apache.org>.
chitralverma commented on PR #6877:
URL: https://github.com/apache/opendal/pull/6877#issuecomment-3626467511
@Xuanwo ready for review, before more PRs merge :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org