[jira] [Commented] (AMQ-6191) For HTTP Transport, make the embedded Jetty server Request Log configurable

["Christopher L. Shannon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-6191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177883#comment-15177883 ] 

Christopher L. Shannon commented on AMQ-6191:
---------------------------------------------

Thanks for the contribution and this is a good idea to be able to enable the request log but there are a few issues I see with the patch. 

1) There were changes made in the past couple of days so this needs to be rebased against that.
2) There should be a way to configure the different options.  Things like timezone and retained days need to be configurable.  Since this Jetty log isn't log4j and we can't configure it that way, my preference would be able to configure these settings on the transport url.  Take a look at the new HttpOptions object that was just added and how that is being set from the configuration URL in AMQ-6182
3) The default log directory should be the same directory as the rest of the logs, ie ${activemq.base}/data/
4) This should probably apply to the Websocket transports as well.

You can either submit a new patch with these changes or when I get a chance I can take care of it.

> For HTTP Transport, make the embedded Jetty server Request Log configurable
> ---------------------------------------------------------------------------
>
>                 Key: AMQ-6191
>                 URL: https://issues.apache.org/jira/browse/AMQ-6191
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Transport
>    Affects Versions: 5.11.1
>            Reporter: Nate Klein
>            Priority: Minor
>         Attachments: patchfile-5.13.1.txt, patchfile.txt
>
>
> I recently had a need to troubleshoot some connectivity issues between client application and broker, and wanted to look at the access logs of the embedded Jetty server in the HTTP transport.  This patch adds a way to configure this file from the Connector URL.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)