You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2019/12/26 11:03:10 UTC
[GitHub] [hadoop-ozone] maobaolong opened a new pull request #394:
HDDS-2813. Provide a ByteArrayCodec to CodecRegistry
maobaolong opened a new pull request #394: HDDS-2813. Provide a ByteArrayCodec to CodecRegistry
URL: https://github.com/apache/hadoop-ozone/pull/394
## What changes were proposed in this pull request?
TypedTable as a special RDBTable, it should compatible with RDBTable, so byte[] should be support by default. In my case, i use TypedTable as a manager to manage my rocksdb, the key is byte[], the value is a structed class.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2813
## How was this patch tested?
The PR with a unit test inside.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on issue #394: HDDS-2813.
Provide a ByteArrayCodec to CodecRegistry
Posted by GitBox <gi...@apache.org>.
maobaolong commented on issue #394: HDDS-2813. Provide a ByteArrayCodec to CodecRegistry
URL: https://github.com/apache/hadoop-ozone/pull/394#issuecomment-569560711
@cxorm PTAL, Thx very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] cxorm commented on issue #394: HDDS-2813. Provide a
ByteArrayCodec to CodecRegistry
Posted by GitBox <gi...@apache.org>.
cxorm commented on issue #394: HDDS-2813. Provide a ByteArrayCodec to CodecRegistry
URL: https://github.com/apache/hadoop-ozone/pull/394#issuecomment-569064845
Thanks @maobaolong for the work.
```checkstyle``` reported some error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on issue #394: HDDS-2813.
Provide a ByteArrayCodec to CodecRegistry
Posted by GitBox <gi...@apache.org>.
maobaolong commented on issue #394: HDDS-2813. Provide a ByteArrayCodec to CodecRegistry
URL: https://github.com/apache/hadoop-ozone/pull/394#issuecomment-570577883
@nandakumar131 Please take a look, thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on issue #394: HDDS-2813.
Provide a ByteArrayCodec to CodecRegistry
Posted by GitBox <gi...@apache.org>.
maobaolong commented on issue #394: HDDS-2813. Provide a ByteArrayCodec to CodecRegistry
URL: https://github.com/apache/hadoop-ozone/pull/394#issuecomment-571117975
@nandakumar131 Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] cxorm edited a comment on issue #394: HDDS-2813.
Provide a ByteArrayCodec to CodecRegistry
Posted by GitBox <gi...@apache.org>.
cxorm edited a comment on issue #394: HDDS-2813. Provide a ByteArrayCodec to CodecRegistry
URL: https://github.com/apache/hadoop-ozone/pull/394#issuecomment-569064845
Thanks @maobaolong for the work.
```checkstyle``` detected violations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] cxorm edited a comment on issue #394: HDDS-2813.
Provide a ByteArrayCodec to CodecRegistry
Posted by GitBox <gi...@apache.org>.
cxorm edited a comment on issue #394: HDDS-2813. Provide a ByteArrayCodec to CodecRegistry
URL: https://github.com/apache/hadoop-ozone/pull/394#issuecomment-570115371
Thanks @maobaolong for this PR.
I think this PR should be reviewed by committer/PMC cause it is about new feature.
Would you talk about this feature in [slack](https://s.apache.org/slack-invite) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on issue #394: HDDS-2813.
Provide a ByteArrayCodec to CodecRegistry
Posted by GitBox <gi...@apache.org>.
maobaolong commented on issue #394: HDDS-2813. Provide a ByteArrayCodec to CodecRegistry
URL: https://github.com/apache/hadoop-ozone/pull/394#issuecomment-569171716
BTW, Please help me to review another PR https://github.com/apache/hadoop-ozone/pull/391
It relate to CodecRegistry too. Thank you @cxorm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] maobaolong commented on issue #394: HDDS-2813.
Provide a ByteArrayCodec to CodecRegistry
Posted by GitBox <gi...@apache.org>.
maobaolong commented on issue #394: HDDS-2813. Provide a ByteArrayCodec to CodecRegistry
URL: https://github.com/apache/hadoop-ozone/pull/394#issuecomment-569171352
@cxorm Thank you for remind me, so careless i am. I've fixed the style problem and pass the checkstyle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] cxorm commented on issue #394: HDDS-2813. Provide a
ByteArrayCodec to CodecRegistry
Posted by GitBox <gi...@apache.org>.
cxorm commented on issue #394: HDDS-2813. Provide a ByteArrayCodec to CodecRegistry
URL: https://github.com/apache/hadoop-ozone/pull/394#issuecomment-570115371
Thanks @maobaolong for this PR.
I think this PR should be reviewed by committer/PMC cause it is about new feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] nandakumar131 merged pull request #394: HDDS-2813.
Provide a ByteArrayCodec to CodecRegistry
Posted by GitBox <gi...@apache.org>.
nandakumar131 merged pull request #394: HDDS-2813. Provide a ByteArrayCodec to CodecRegistry
URL: https://github.com/apache/hadoop-ozone/pull/394
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org