You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by jb...@apache.org on 2009/01/06 22:31:14 UTC
svn commit: r732127 -
/geronimo/server/trunk/plugins/system-database/sysdb-portlets/src/main/webapp/WEB-INF/view/internaldb/runSQLNormal.jsp
Author: jbohn
Date: Tue Jan 6 13:31:14 2009
New Revision: 732127
URL: http://svn.apache.org/viewvc?rev=732127&view=rev
Log:
remove unnecessary eval statement from sql portlet
Modified:
geronimo/server/trunk/plugins/system-database/sysdb-portlets/src/main/webapp/WEB-INF/view/internaldb/runSQLNormal.jsp
Modified: geronimo/server/trunk/plugins/system-database/sysdb-portlets/src/main/webapp/WEB-INF/view/internaldb/runSQLNormal.jsp
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/system-database/sysdb-portlets/src/main/webapp/WEB-INF/view/internaldb/runSQLNormal.jsp?rev=732127&r1=732126&r2=732127&view=diff
==============================================================================
--- geronimo/server/trunk/plugins/system-database/sysdb-portlets/src/main/webapp/WEB-INF/view/internaldb/runSQLNormal.jsp (original)
+++ geronimo/server/trunk/plugins/system-database/sysdb-portlets/src/main/webapp/WEB-INF/view/internaldb/runSQLNormal.jsp Tue Jan 6 13:31:14 2009
@@ -28,17 +28,17 @@
var <portlet:namespace/>requiredFields2 = new Array("sqlStmts");
function <portlet:namespace/>validateForm1(){
- var action = eval("document.forms[<portlet:namespace/>formName].elements['action']");
+ var action = document.forms[<portlet:namespace/>formName].elements['action'];
action.value="Create";
return textElementsNotEmpty(<portlet:namespace/>formName, <portlet:namespace/>requiredFields);
}
function <portlet:namespace/>validateForm2(){
- var action = eval("document.forms[<portlet:namespace/>formName].elements['action']");
+ var action = document.forms[<portlet:namespace/>formName].elements['action'];
action.value="Delete";
return confirm('<fmt:message key="internaldb.runSQLNormal.reallyDeleteDatabase"/>')
}
function <portlet:namespace/>validateForm3(){
- var action = eval("document.forms[<portlet:namespace/>formName].elements['action']");
+ var action = document.forms[<portlet:namespace/>formName].elements['action'];
action.value="Run SQL";
return textElementsNotEmpty(<portlet:namespace/>formName, <portlet:namespace/>requiredFields2);
}